931514 - JavaScript Error: currentCard.addEventListener is not a function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Zac C (:zac)]

E/GeckoConsole(  139): [JavaScript Error: "TypeError: currentCard.addEventListener is not a function" {file: "app://system.gaiamobile.org/js/cards_view.js" line: 542}]


STR:
0. Setup logcat/logging
1. Open an app
2. Open cards view
3. Kill the app
4. Observe the logcat


Hamachi
Gecko  http://hg.mozilla.org/mozilla-central/rev/5a9ac6fed6ff
Gaia  15c1089aea0490b9b73bc915b1495b3faa1b023c
BuildID 20131025040252
Version 27.0a1

Comment 2

[Jason Smith [:jsmith]]

Turns out the JS error is a separate issue, so reopening.

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: github PR

I see this several times a day and it makes me crazy. So here is a patch :)

STR:
* launch SMS
* long press home
* kill SMS by swiping up (it must be the last app)

I don't know if that happens when we kill with the cross, I bet it is too, but this is the STR I do several times a day :)

Comment 4

[Aus Lacroix [:aus]]

Hi Julien! I think this is fixed in my PR for bug 939809.

Comment 5

[Aus Lacroix [:aus]]

Commit: https://github.com/mozilla-b2g/gaia/commit/91a572e0fb84a12e7499a718dd7e50192a62a442

Let me know if this fixes the problem. If not, Julien, hopefully rebasing won't be too painful. :(

Comment 6

[Julien Wajsberg [:julienw]]

Heh too bad I looked at it the very day you finished your work :)

I'm removing the review request until I check.

Comment 7

[Gregor Wagner [:gwagner]]

It's still happening on trunk:
E/GeckoConsole(  142): [JavaScript Error: "TypeError: currentCard.addEventListener is not a function" {file: "app://system.gaiamobile.org/js/cards_view.js" line: 569}]

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8379745 [details] [review]
github PR

Rebased and requesting review again.

I went ahead and did a failing test too!

I don't understand why we have so many setTimeout(done) whereas using sinon.clock.tick() could work... but I didn't even needed this for my patch anyway.

Comment 9

[Julien Wajsberg [:julienw]]

master: 0dde42761b40cdb21079ff82f703fa60b7785110

thanks!