JavaScript Error: currentCard.addEventListener is not a function

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: zac, Assigned: julienw)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
E/GeckoConsole(  139): [JavaScript Error: "TypeError: currentCard.addEventListener is not a function" {file: "app://system.gaiamobile.org/js/cards_view.js" line: 542}]


STR:
0. Setup logcat/logging
1. Open an app
2. Open cards view
3. Kill the app
4. Observe the logcat


Hamachi
Gecko  http://hg.mozilla.org/mozilla-central/rev/5a9ac6fed6ff
Gaia  15c1089aea0490b9b73bc915b1495b3faa1b023c
BuildID 20131025040252
Version 27.0a1

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 915165
Turns out the JS error is a separate issue, so reopening.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(Assignee)

Comment 3

4 years ago
Created attachment 8379745 [details] [review]
github PR

I see this several times a day and it makes me crazy. So here is a patch :)

STR:
* launch SMS
* long press home
* kill SMS by swiping up (it must be the last app)

I don't know if that happens when we kill with the cross, I bet it is too, but this is the STR I do several times a day :)
Assignee: nobody → felash
Attachment #8379745 - Flags: review?(alive)

Comment 4

4 years ago
Hi Julien! I think this is fixed in my PR for bug 939809.
Depends on: 939809

Comment 5

4 years ago
Commit: https://github.com/mozilla-b2g/gaia/commit/91a572e0fb84a12e7499a718dd7e50192a62a442

Let me know if this fixes the problem. If not, Julien, hopefully rebasing won't be too painful. :(
(Assignee)

Comment 6

4 years ago
Heh too bad I looked at it the very day you finished your work :)

I'm removing the review request until I check.
(Assignee)

Updated

4 years ago
Attachment #8379745 - Flags: review?(alive)
It's still happening on trunk:
E/GeckoConsole(  142): [JavaScript Error: "TypeError: currentCard.addEventListener is not a function" {file: "app://system.gaiamobile.org/js/cards_view.js" line: 569}]
(Assignee)

Comment 8

4 years ago
Comment on attachment 8379745 [details] [review]
github PR

Rebased and requesting review again.

I went ahead and did a failing test too!

I don't understand why we have so many setTimeout(done) whereas using sinon.clock.tick() could work... but I didn't even needed this for my patch anyway.
Attachment #8379745 - Flags: review?(alive)
Attachment #8379745 - Flags: review?(alive) → review+
(Assignee)

Comment 9

4 years ago
master: 0dde42761b40cdb21079ff82f703fa60b7785110

thanks!
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.