931555 - [Bluetooth] - wrong button style on file transfer failed screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We need to add class "danger" to https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/transfer.html#L53

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Hey Gina,
can you review this one :) Thanks in advance :)

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 823004 [details] [review]
patch for Gaia/master

Sorry. I'd like to but I can't review this patch.

I think Ian might be the right person. ;)

Comment 3

[[e-mail], [e-mail]]

Hi Pavel,

I'm happy to review the patch. Please set the flag for me.:)
Thanks.

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 823004 [details] [review]
patch for Gaia/master

Thanks guys :)

Comment 5

[[e-mail], [e-mail]]

Comment on attachment 823004 [details] [review]
patch for Gaia/master

The button style is correct, after applied the patch. r=me
Thanks.

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Ian,

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/ad116b32fac36c15fca0d371274f627776c248af

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2013-11-01-10-53-02.png

Verified:
Gaia   92c097fd7ac9886f937d9decb0e03ab673deaa1b
SourceStamp 518f5bff0ae4
BuildID 20131029040205
Version 28.0a1
Buri