931640 - [B2G][1.2][l10n][Settings] "Reset PIN2 code" string is not localizable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Natalya Kot [:nkot]]

Attachment: screenshot

Description:
"Reset PIN2 code" string is not translated in Russian, shown in English

Prerequisites:
Have a SIM PIN2 set on Test device

Repro Steps:
1) Updated Buri to BuildID: 20131025004000
2) Set device language to German (Deutsch)
3) Open Settings
4) Open Call Settings
5) Tap Fixed dialing numbers to open its menu
6) Observe the screen

Actual:
 "Reset PIN2 code" string is shown in English

Expected:
 "Reset PIN2 code" is shown in German (should be "PIN2 zurücksetzen" according to http://hg.mozilla.org/releases/gaia-l10n/v1_2/de/file/359a89cc4068/apps/settings/settings.properties) 

Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131025004000
Gaia: 606517ceafe0950c2b89822d5f13353743334f2c
Gecko: 5eabd267ef04
Version: 26.0a2
Firmware Version: US_20131015

Repro frequency: 100%
See attached screenshot

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The hardcoded English (fallback) text is shown because at

https://github.com/mozilla-b2g/gaia/blob/v1.2/apps/settings/elements/call_fdn_settings.html#L39

fdn-resetPIN2 should be fdnReset, see

https://github.com/mozilla-b2g/gaia/blob/v1.2/apps/settings/locales/settings.en-US.properties#L140

Comment 2

[Soumya Kanti Chakraborty]

I can work on this bug, please assign it to me.

Comment 3

[Soumya Kanti Chakraborty]

Attachment: Bug 931640 patch

Comment 4

[Soumya Kanti Chakraborty]

Attachment: Bug 931640 patch

Please consider the new pull request

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 824514 [details] [review]
Bug 931640 patch

I am not a module peer, so I can't review that. Redirecting to kaze for review. The commit message should be update because the issue exists for all localizations.

Comment 6

[Soumya Kanti Chakraborty]

I have updated the commit message.

Comment 7

[Fabien Cazenave [:kaze]]

Comment on attachment 824514 [details] [review]
Bug 931640 patch

Thanks for the fix!

Comment 8

[Fabien Cazenave [:kaze]]

Merged on master: https://github.com/mozilla-b2g/gaia/commit/8c167fb9a88e894fa974e7ed3cf88fbbdabf6fa8

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 8c167fb9a88e894fa974e7ed3cf88fbbdabf6fa8 to:
v1.2: e53704bd8c123ea7506e90198aa737473c125a4b