[Marionette] Modify the output format for repeat option

RESOLVED FIXED in mozilla28

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: askeing, Assigned: askeing)

Tracking

unspecified
mozilla28
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
The output of repeat option is a little bit weird now.
For example, with "--repeat=4" option, the output will be:
  ROUND 4
  -------
  xxx... (1st run)
  
  ROUND 3
  -------
  xxx... (1st run)
  
  ROUND 2
  -------
  xxx...
  
  ROUND 1
  -------
  xxx...
  
  ROUND 0
  -------
  xxx...
  
  SUMMARY
  -------
  passed: X
  failed: Y
  todo: Z
(Assignee)

Comment 1

5 years ago
(In reply to Askeing Yen[:askeing] from comment #0)
> The output of repeat option is a little bit weird now.
> For example, with "--repeat=4" option, the output will be:
  ROUND 4
  -------
  xxx... (1st run)
  
  ROUND 3
  -------
  xxx... (2nd run)
  
  ROUND 2
  -------
  xxx... (3rd run)
  
  ROUND 1
  -------
  xxx... (4th run)
  
  ROUND 0
  -------
  xxx... (5th run)
  
  SUMMARY
  -------
  passed: X
  failed: Y
  todo: Z

Sorry for the typo.
(Assignee)

Comment 2

5 years ago
IMO, the following output format will be better for "--repeat=4" option:

  xxx... (1st run)
  
  REPEAT 1
  -------
  xxx... (2nd run)
  
  REPEAT 2
  -------
  xxx... (3rd run)
  
  REPEAT 3
  -------
  xxx... (4th run)
  
  REPEAT 4
  -------
  xxx... (5th run)
(Assignee)

Comment 3

5 years ago
Created attachment 823199 [details] [diff] [review]
bug-931681-fix.patch

Need feedback.
Attachment #823199 - Flags: feedback?
Comment on attachment 823199 [details] [diff] [review]
bug-931681-fix.patch

Review of attachment 823199 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. I especially like the removal of the 'ROUND 0' for when the --repeat argument is not specified. Requesting feedback from Zac too.
Attachment #823199 - Flags: feedback?(zcampbell)
Attachment #823199 - Flags: feedback?
Attachment #823199 - Flags: feedback+

Comment 6

5 years ago
Comment on attachment 823199 [details] [diff] [review]
bug-931681-fix.patch

A non-technical r+ from me. I like it very much, it sounds much less like a boxing match now :)
Attachment #823199 - Flags: feedback?(zcampbell) → feedback+
(Assignee)

Comment 7

5 years ago
Comment on attachment 823199 [details] [diff] [review]
bug-931681-fix.patch

review?
Attachment #823199 - Flags: review?
No reviewer was listed, so I just chimed in. Feel free to land on m-i.
(Assignee)

Comment 9

5 years ago
Created attachment 825081 [details] [diff] [review]
bug-931681-fix.patch

modified the comment of patch.
Attachment #823199 - Attachment is obsolete: true
Attachment #825081 - Flags: review+
Attachment #825081 - Flags: feedback+
(Assignee)

Comment 11

5 years ago
Hi jgriffin, could you please help us to land this patch?

Thank you.
Flags: needinfo?(jgriffin)
The trees are currently closed; I'll land this when they re-open.
Keywords: checkin-needed
Flags: needinfo?(jgriffin)
https://hg.mozilla.org/mozilla-central/rev/a33e3cb6c17d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.