931683 - Support NOTed filtering in MozTrap

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: MozTrap, defect)

Description

[shiro Bai [:shiro]]

I'm gonna to release a patch for NOTed filtering in MozTrap.
That is, you can exclude something from your queries now.

The usage is like the description in the link below.
https://bugzilla.mozilla.org/show_bug.cgi?id=927240
Just append &filter-not-<key> (e.g. filter-not-tag) to url.

Comment 1

[shiro Bai [:shiro]]

Attachment: Patch for this bug

Comment 2

[Cameron Dawson [:camd]]

From my comment on the PR:



I like the idea of this. I think it would be a really useful feature. However, I think this PR doesn't quite cover the feature as it would need to be. See this tracker story: https://www.pivotaltracker.com/story/show/41414801

We need a UI component to be able to display this in a "chicklet" like the other filters, but show that it's excluding, rather than including items. (like a circle with a slash through it). It also looks like the only way to do this currently is to add the filter to the URL? We should provide a way for a user to invoke this in the UI. So, much like we have a button next to the filter value for "pinning" the filter, we could have the "negate" button there, too.

And this will need unit tests to cover the functionality.

But, again, this would be awesome to have. Especially for things like results, where you would like to see all tests except ones that have been already run, for example.

Comment 3

[shiro Bai [:shiro]]

I just pushed a commit to cover keyword filter.
Thanks for Cameron's reminder.

Comment 4

[shiro Bai [:shiro]]

(In reply to shiro Bai [:shiro] from comment #3)
> I just pushed a commit to cover keyword filter.
> Thanks for Cameron's reminder.

Sorry, I just found that I commented the wrong bug.
(should be https://bugzilla.mozilla.org/show_bug.cgi?id=741450)

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 823187 [details] [review]
Patch for this bug

This looks good.  Just need to get the unit tests working and this can be merged.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-closing remaining MozTrap bugs as WONTFIX, due to 1) the Mozilla-hosted instance being decommissioned (see https://wiki.mozilla.org/TestEngineering/Testrail), and, for now, 2) the still-up code archived at its GitHub page: https://github.com/mozilla/moztrap (we'll decide what's next for that, in the near future).

See also the history and more-detailed discussion which led us here, at https://groups.google.com/forum/#!topic/mozilla.dev.quality/Sa75hV8Ywvk

(If you'd like, you should be able to filter these notification emails using at least the unique string of "Sa75hV8Ywvk" in the message body.

Thanks!