Closed Bug 931719 Opened 6 years ago Closed 6 years ago

[HW test] unlock button in orientation test test doesn't work

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tjao, Assigned: tjao)

References

Details

Attachments

(1 file)

It seems that some buttons are removed but not the corresponding part of Javascript. This would cause some null exception and breaks the last buttons .
Assignee: nobody → tjao
Blocks: eng-mode
Attachment #825741 - Flags: review?(flin)
please check comment in github
Patch updated, also some comment on github.
Comment on attachment 825741 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13279

looks good to me, thank you!
Attachment #825741 - Flags: review?(flin) → review+
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/ccdf357ea150fc7d8b8a4b74c7adf31e7a57e465
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.