931732 - Remove #if 0 code from jit/arm/*

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

See bug 931039 comment 2. There's some #if 0 code in jit/arm/*.cpp that we should either remove or enable somehow.

Comment 1

[:Cykesiopka]

Attachment: bug931732_v1.patch

No idea if this code could still be re-enabled somehow, but here is a patch that just removes it.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8390967 [details] [diff] [review]
bug931732_v1.patch

Review of attachment 8390967 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=me with the changes requested below.

::: js/src/jit/arm/CodeGenerator-arm.cpp
@@ -248,5 @@
>      // implement this.  Moreover, If it isn't a local branch, it will be large
>      // and possibly slow.  I believe that the correct way to handle this is to
>      // subclass label into a fatlabel, where we generate enough room for a load
>      // before the branch
> -#if 0

Can you remove the comment right before this line too? It's no longer needed.

@@ +252,3 @@
>      // We could not use a jump table, either because all bailout IDs were
>      // reserved, or a jump table is not optimal for this frame size or
>      // platform. Whatever, we will generate a lazy bailout.

Change this comment to:

// On ARM we don't use a bailout table.

Comment 3

[:Cykesiopka]

Attachment: bug931732_v2.patch

+ Comment changes

Carrying over r+.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/138778313096

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/138778313096