Closed Bug 931732 Opened 6 years ago Closed 6 years ago

Remove #if 0 code from jit/arm/*

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jandem, Assigned: Cykesiopka)

Details

Attachments

(1 file, 1 obsolete file)

See bug 931039 comment 2. There's some #if 0 code in jit/arm/*.cpp that we should either remove or enable somehow.
Attached patch bug931732_v1.patch (obsolete) — Splinter Review
No idea if this code could still be re-enabled somehow, but here is a patch that just removes it.
Attachment #8390967 - Flags: review?(jdemooij)
Comment on attachment 8390967 [details] [diff] [review]
bug931732_v1.patch

Review of attachment 8390967 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=me with the changes requested below.

::: js/src/jit/arm/CodeGenerator-arm.cpp
@@ -248,5 @@
>      // implement this.  Moreover, If it isn't a local branch, it will be large
>      // and possibly slow.  I believe that the correct way to handle this is to
>      // subclass label into a fatlabel, where we generate enough room for a load
>      // before the branch
> -#if 0

Can you remove the comment right before this line too? It's no longer needed.

@@ +252,3 @@
>      // We could not use a jump table, either because all bailout IDs were
>      // reserved, or a jump table is not optimal for this frame size or
>      // platform. Whatever, we will generate a lazy bailout.

Change this comment to:

// On ARM we don't use a bailout table.
Attachment #8390967 - Flags: review?(jdemooij) → review+
+ Comment changes

Carrying over r+.
Assignee: nobody → cykesiopka.bmo
Attachment #8390967 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/138778313096
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.