931748 - View count missing from both questions & questions listing page

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P3)

Description

[Noah (NoahSUMO/SolidSnake) [:Noah]]

For sometime now, the question view counts have been lost. From both individual questions and questions listing page. I'm not sure why.

After going back thru quite a few pages, I tracked down when thread view counts stopped being collected: Aug 26, 2013 6pm

See: https://support.mozilla.org/en-US/questions?sort=created&page=272

Threads before this date all have their view counts saved and displayed.

Examples:
Views still here:
https://support.mozilla.org/en-US/questions/969474
https://support.mozilla.org/en-US/questions/966714
https://support.mozilla.org/en-US/questions/967651

Views missing:
https://support.mozilla.org/en-US/questions/969475
https://support.mozilla.org/en-US/questions/974029
https://support.mozilla.org/en-US/questions/973685

I guess if I had been paying attention I would've discovered this sooner. :P But I've been busy with work.

I'm guessing this was turned off when troubleshooting something or doing maintenance and forgot to be turned back on.

Related bugs: Bug 857534 & Bug 872198

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

The cron job has been failing. Not sure what's going on.

Traceback (most recent call last):
  File "manage.py", line 47, in <module>
    execute_manager(settings)
  File "/data/support/www/support.mozilla.org/kitsune/vendor/src/django/django/core/management/__init__.py", line 459, in execute_manager
    utility.execute()
  File "/data/support/www/support.mozilla.org/kitsune/vendor/src/django/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/data/support/www/support.mozilla.org/kitsune/vendor/src/django/django/core/management/base.py", line 196, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/data/support/www/support.mozilla.org/kitsune/vendor/src/django/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "/data/support/www/support.mozilla.org/kitsune/vendor/src/django-cronjobs/cronjobs/management/commands/cron.py", line 38, in handle
    registered[script](*args)
  File "/data/support/www/support.mozilla.org/kitsune/kitsune/questions/cron.py", line 134, in reload_question_traffic_stats
    QuestionVisits.reload_from_analytics()
  File "/data/support/www/support.mozilla.org/kitsune/kitsune/questions/models.py", line 563, in reload_from_analytics
    settings.GA_START_DATE, date.today())
  File "/data/support/www/support.mozilla.org/kitsune/kitsune/sumo/googleanalytics.py", line 183, in pageviews_by_question
    for result in results['rows']:
TypeError: 'NoneType' object is unsubscriptable

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

I wasn't able to repro locally when I tried running the cronjob. Guesstimating it will take 2pts to figure out.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Moving along during sprint planning.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now:
https://github.com/mozilla/kitsune/commit/4c571da884e602d3c4f2f63940787cfc6339cad4

PR was here:
https://github.com/mozilla/kitsune/pull/1736