931751 - Gallery crashed when user tries to click the 'EDIT' option

Status: RESOLVED DUPLICATE of bug 922368

(Core :: Graphics, defect, P2)

Description

[saminath]

Attachment: Gallery_Crashreport.txt

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130911164256

Steps to reproduce:

Gecko 	  fd5be0de78d827056832a65431bb43b3c5311a7b
Gaia  	  34c6aeb027728624a478f299a34c28a7f7b43e64
Build-ID    20131021141837
P.version   27.0a1
Device     Nexus-4

1. Run the Gallery Application
2. Select the picture
3. Click the 'EDIT' option in the Bottom
4. Application closed and Error logs in the Logcat console



Actual results:

Gallery Application Crashed.


Expected results:

Edit and Save the Picture

Comment 1

[saminath]

Problem was identified in the GLScreenBuffer::AssureBlitted().

GLExtension not having support for EXT_framebuffer_blit and ANGLE_framebuffer_blit, Due to that it Asserted!.


E/GeckoConsole( 6187): [JavaScript Error: "NS_ERROR_FAILURE: " {file: "app://gallery.gaiamobile.org/js/ImageEditor.js" line: 1264}]
E/GeckoConsole( 6187): [JavaScript Error: "NS_ERROR_FAILURE: " {file: "app://gallery.gaiamobile.org/js/ImageEditor.js" line: 1264}]
F/MOZ_Assert( 6187): Assertion failure: mGL->IsExtensionSupported(GLContext::EXT_framebuffer_blit) || mGL->IsExtensionSupported(GLContext::ANGLE_framebuffer_blit), at ../../../gecko/gfx/gl/GLScreenBuffer.cpp:340
F/libc    ( 6187): Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1), thread 6187 (Gallery)
...

Comment 2

[saminath]

Attachment: 931751_glcontext.patch

Comment 3

[saminath]

GLExtension support is added for EXT_framebuffer_blit and ANGLE_framebuffer_blit in GLContext:init().
This will fix the problem.

Created attachment 931751

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 824491 [details] [diff] [review]
931751_glcontext.patch

Review of attachment 824491 [details] [diff] [review]:
-----------------------------------------------------------------

This just (probably incorrectly) marks these extensions as supported on Qualcomm hardware. This bug has the same cause as bug 922368, so I'm going to mark it as duplicate, since that bug already has an r+'d patch. (I just forgot to commit it)