931798 - Story - Auto restore session after a switch to desktop happens

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P1)

Description

[Brian R. Bondy [:bbondy]]

When starting up the browser the following pref is checked:
browser.sessionstore.resume_session_once

If it is set to true then the session is restored. 
Then the pref is auto reset to false.
(See http://dxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/nsSessionStartup.js#l139 for more info, but not needed for this task).

This bug is to set that pref to true before switching to Desktop.

We should also add browser.sessionstore.resume_session_once to the list of shared prefs here:
http://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#l4757

p=1

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: bug931798_restorenextrestart.diff

For oak only for now

Comment 2

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/projects/oak/rev/9da01190f0e5

Bug 935099 will track the landing on m-c.
When it lands on m-c a new comment will be added here as well with the m-c changeset.
This is being done so we can still use scrumbugs efficiently. 
See bug 935099 for further details.

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: rev1 rebased for australis

Carrying forward r+

Comment 4

[Brian R. Bondy [:bbondy]]

Repushed to post-australis oak:
https://hg.mozilla.org/projects/oak/rev/eecf7c2a4823

Comment 5

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/fx-team/rev/fb3ae66def36

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fb3ae66def36

Comment 7

[Manuela Muntean [Away]]

- on Win 8.1 Pro, with latest Nightly

If I open the desktop browser, "browser.sessionstore.resume_session_once" is set to false by default. When I switch to Metro browser, the pref has the value true. Then, when I relaunch in Desktop mode, the value of the pref is still false.

Is this the intended behavior?

Comment 8

[Brian R. Bondy [:bbondy]]

I don't think so but this will be covered in a different session restore working consistently bug if needed.

Comment 9

[Manuela Muntean [Away]]

But are the steps from comment 7 the right ones to follow, in order to verify this bug?

Comment 10

[Brian R. Bondy [:bbondy]]

I'm not sure how to verify this because the browser can change it on startup.

Comment 11

[Manuela Muntean [Away]]

Does anyone have any suggestions in how to verify this issue?

Comment 12

[Marina Samuel [:emtwo]]

I think the intended effect of this bug is to ensure that a session is restored when switching to/from desktop and metro, instead of starting a new session. So verifying that the tabs are carried to the other mode is an example. However, the session restore may not be done 100% correctly yet, since bug 924886 is still in progress.

Comment 13

[Manuela Muntean [Away]]

Marking this verified as fixed, for iteration #20, based on comment 12: a session is restored (almost 100% correctly, considering bug 924886 as mentioned above) when switching to/from Desktop and Metro.