931834 - New infobar design is broken on Windows

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Paul Rouget [:paul]]

See attachment 823373 [details]. We can see the buttons' borders.

Comment 1

[Albert Juhé]

Not sure but maybe is this line of my previous patch?

> .highlighter-nodeinfobar-button {
>   -moz-appearance: none;
>-  border: 0 solid hsla(210,8%,5%,.45);
>   padding: 0;
>   width: 26px;

Comment 2

[Paul Rouget [:paul]]

(In reply to Albert Juhé from comment #1)
> Not sure but maybe is this line of my previous patch?
> 
> > .highlighter-nodeinfobar-button {
> >   -moz-appearance: none;
> >-  border: 0 solid hsla(210,8%,5%,.45);
> >   padding: 0;
> >   width: 26px;

Yes. I believe doing this should work:

>  .highlighter-nodeinfobar-button {
>   -moz-appearance: none;
>-  border: 0 solid hsla(210,8%,5%,.45);
>+  border-width: 0;

Comment 3

[Albert Juhé]

I have Windows 7 installed in a virtual machine but I am not sure if it will be able to build Firefox. Is there any other way to test it?

Comment 4

[Paul Rouget [:paul]]

(In reply to Albert Juhé from comment #3)
> I have Windows 7 installed in a virtual machine but I am not sure if it will
> be able to build Firefox. Is there any other way to test it?

I'll provide you a build. Attach a patch, I'll do the rest. Thanks!

Comment 5

[Albert Juhé]

Attachment: Bug 931834 - New infobar design is broken on Windows; r=paul

Comment 6

[Paul Rouget [:paul]]

Comment on attachment 823425 [details] [diff] [review]
Bug 931834 - New infobar design is broken on Windows; r=paul

Yep. That works.

Comment 7

[Paul Rouget [:paul]]

Albert, once you get a r+, add "checkin-needed" in the keyword field (I changed your bugzilla privileges, you can now confirm bugs and edit all aspects of any bug).

Comment 8

[Albert Juhé]

Done, thanks. ;-)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/f081f22d4eff

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f081f22d4eff

Comment 11

[Paul Rouget [:paul]]

Comment on attachment 823425 [details] [diff] [review]
Bug 931834 - New infobar design is broken on Windows; r=paul

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 927815
User impact if declined: windows user will see grey lines in the infobar
Testing completed (on m-c, etc.): fx-team, m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f081f22d4eff

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2da1e7e586a4

Comment 14

[Bogdan Maris, Desktop Test Engineering (Out till 23th April)]

Mozilla/5.0 (Windows NT 6.2; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (Windows NT 6.2; rv:28.0) Gecko/20100101 Firefox/28.0

Verified as fixed on latest Aurora (buildID: 20131107004005) and latest Nightly (buileID: 20131107030200).