Closed
Bug 931834
Opened 11 years ago
Closed 11 years ago
New infobar design is broken on Windows
Categories
(DevTools :: Inspector, defect)
Tracking
(firefox27 verified, firefox28 verified)
VERIFIED
FIXED
Firefox 28
People
(Reporter: paul, Assigned: me)
References
Details
Attachments
(1 file)
790 bytes,
patch
|
paul
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
See attachment 823373 [details]. We can see the buttons' borders.
Assignee | ||
Comment 1•11 years ago
|
||
Not sure but maybe is this line of my previous patch?
> .highlighter-nodeinfobar-button {
> -moz-appearance: none;
>- border: 0 solid hsla(210,8%,5%,.45);
> padding: 0;
> width: 26px;
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to Albert Juhé from comment #1) > Not sure but maybe is this line of my previous patch? > > > .highlighter-nodeinfobar-button { > > -moz-appearance: none; > >- border: 0 solid hsla(210,8%,5%,.45); > > padding: 0; > > width: 26px; Yes. I believe doing this should work: > .highlighter-nodeinfobar-button { > -moz-appearance: none; >- border: 0 solid hsla(210,8%,5%,.45); >+ border-width: 0;
Assignee | ||
Comment 3•11 years ago
|
||
I have Windows 7 installed in a virtual machine but I am not sure if it will be able to build Firefox. Is there any other way to test it?
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Albert Juhé from comment #3) > I have Windows 7 installed in a virtual machine but I am not sure if it will > be able to build Firefox. Is there any other way to test it? I'll provide you a build. Attach a patch, I'll do the rest. Thanks!
Assignee: nobody → aljullu
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #823425 -
Flags: review?(paul)
Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 823425 [details] [diff] [review] Bug 931834 - New infobar design is broken on Windows; r=paul Yep. That works.
Attachment #823425 -
Flags: review?(paul) → review+
Reporter | ||
Comment 7•11 years ago
|
||
Albert, once you get a r+, add "checkin-needed" in the keyword field (I changed your bugzilla privileges, you can now confirm bugs and edit all aspects of any bug).
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 8•11 years ago
|
||
Done, thanks. ;-)
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f081f22d4eff
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f081f22d4eff
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Reporter | ||
Comment 11•11 years ago
|
||
Comment on attachment 823425 [details] [diff] [review] Bug 931834 - New infobar design is broken on Windows; r=paul [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 927815 User impact if declined: windows user will see grey lines in the infobar Testing completed (on m-c, etc.): fx-team, m-c Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #823425 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #823425 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2da1e7e586a4
status-firefox27:
--- → fixed
status-firefox28:
--- → fixed
Comment 14•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.2; rv:27.0) Gecko/20100101 Firefox/27.0 Mozilla/5.0 (Windows NT 6.2; rv:28.0) Gecko/20100101 Firefox/28.0 Verified as fixed on latest Aurora (buildID: 20131107004005) and latest Nightly (buileID: 20131107030200).
Status: RESOLVED → VERIFIED
Keywords: verifyme
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•