931859 - servo buildbot config fails to set got_revision in some cases

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jack Moffitt [:jack]]

When builds time out in buildbot, bors gets stuck. In attempting to track this down, I noticed that bors is depending on the setting of got_revision in the JSON output, but when the builds time out this doesn't seem to get set.

See http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/480 for an example timed out build. See  http://servo-buildbot.pub.build.mozilla.org/json/builders/mac/builds?select=-1&select=-2&select=-3&select=-4&select=-5 for JSON output missing got_revision (in "-1"). The latter URL will probably only be valid for a short time.

Comment 1

[[e-mail] (:bhearsum)]

I think we just need to set alwaysRun=True on the set_script_properties step to fix this. That's what we do in ScriptFactory!

Comment 2

[[e-mail] (:bhearsum)]

Attachment: always set properties

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 823409 [details] [diff] [review]
always set properties

Reconfiged the master for this. Should be fixed...hard to verify until we have another timed out job.