+++ This bug was initially created as a clone of Bug #912010 +++ Re-enable test_everythingme_launch_packaged_app.py (looks like timing based failures on TBPL)
Summary: [Keyboard][V1.2] Default Keyboard when all keyboards are de-selected → Re-enable test_everythingme_launch_packaged_app.py (looks like timing based failures on TBPL)
Created attachment 823517 [details] pr on github Rudy, This seems to fix the problem in the test itself, however there is still something strange happening that you figured out in 912010, maybe we don't need to change it at all.
Attachment #823517 - Flags: review?(rlu)
Attachment #823517 - Flags: review?(dave.hunt)
Rudy summarizes what breaks in the test really well here: https://bugzilla.mozilla.org/show_bug.cgi?id=912010#c58
This test used to be very reliable until today :(
Comment on attachment 823517 [details] pr on github This is a workaround until a more suitable fix is found. Could we add a comment preceding the line that's changed with a TODO and referencing the appropriate bug? Also, please include the bug number and reviewers in the commit message.
Attachment #823517 - Flags: review?(dave.hunt) → review-
Comment on attachment 823517 [details] pr on github I don't think I am qualified to review the gaia-ui-tests code. However, if possible I think we should dig into the root cause in keyboard app about the init process. As my comment, Bug912010#c58, we should check why latin inputmethod was not activated correctly in this specific case. Thanks.
Attachment #823517 - Flags: review?(rlu) → feedback-
Whiteboard: [FT:System-Platform], [Sprint:3], [3rd-party-keyboard]
blocking-b2g: --- → koi?
Summary: Re-enable test_everythingme_launch_packaged_app.py (looks like timing based failures on TBPL) → [Keyboard] Ensure first keyboard shown is properly initialized
Created attachment 824142 [details] [review] Pull Request on Github I think tracked down why the inputMethod wasn't being initialized Rudy, does this make sense to you?
Corey's patch looks good to me, though I'd prefer to put the setKeyboardName() call in initKeyboard().
Not blocking but a fix is very welcome.
blocking-b2g: koi? → -
Find me to a+ this patch to v1.2 if that's what landed in master.
Comment on attachment 824142 [details] [review] Pull Request on Github r=me. Corey, Good work, thanks for your help to locate the point and fix it. -- A note to myself, It seems that in this specific case, mozvisibilitychange event would happen very late so that setKeyboardName() would not be invoked. https://bugzilla.mozilla.org/show_bug.cgi?id=845685#c10
Attachment #824142 - Flags: review?(rlu) → review+
master: https://github.com/mozilla-b2g/gaia/commit/b6221a5ecdeb1252c42f6a7b5628c90c1888346b Can we get approval to uplift this onto 1.2 tim?
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Comment on attachment 824142 [details] [review] Pull Request on Github [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 912010 [User impact] if declined: It is possible that the first keyboard shown will not properly initialize its input method. This means things like autocorrect, auto capitalization, etc might not work on the first keyboard displayed. [Testing completed]: device and integration tests, everything still behaves properly [Risk to taking this patch] (and alternatives if risky): low [String changes made]: none
Attachment #824142 - Flags: approval-gaia-v1.2?(timdream)
Comment on attachment 824142 [details] [review] Pull Request on Github My pleasure ;)
Attachment #824142 - Flags: approval-gaia-v1.2?(timdream) → approval-gaia-v1.2+
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1.2 git cherry-pick -x b6221a5ecdeb1252c42f6a7b5628c90c1888346b <RESOLVE MERGE CONFLICTS> git commit
This was uplifted in 90d2ede..cce2ba1
status-b2g-v1.2: affected → fixed
v1.2 reverted: 9d335a436d494c3703e98e195c6d94da4be9a15d https://tbpl-dev.allizom.org/?rev=fc1043ab2d67&tree=Mozilla-B2g26-v1.2
status-b2g-v1.2: fixed → affected
v1.2 reland: 79368fd140ce7d965b533304fccc49148f5d3072
status-b2g-v1.2: affected → fixed
It seems to be a race condition. I cannot manually verify it. But the test result of TBPL works as normal after the patch was landed. Marked as "Verified"
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.