931996 - Add an AppendEllipseToPath helper to Moz2D

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

This code is cribbed from gfxContext::Ellipse.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0fdae4f78c1a

Comment 3

[Ed Morley [:emorley]]

Sadly had to backout this push due to failures linking on Windows:
https://tbpl.mozilla.org/php/getParsedLog.php?id=29971575&tree=Mozilla-Inbound

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c4f51fe7d637
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a750c58e428e
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/9189b08d7d5e

Comment 4

[Ed Morley [:emorley]]

Either this or bug 931915 also resulted in leaks, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=29974755&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=29973338&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=29974475&tree=Mozilla-Inbound

Comment 5

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley UTC+1] from comment #4)
> Either this or bug 931915 also resulted in leaks, eg:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=29974755&tree=Mozilla-
> Inbound
> https://tbpl.mozilla.org/php/getParsedLog.php?id=29973338&tree=Mozilla-
> Inbound
> https://tbpl.mozilla.org/php/getParsedLog.php?id=29974475&tree=Mozilla-
> Inbound

In fact, I think these leaks were bug 926128 (multiple overlapping bustage). Once the compilation failures are fixed - can you run past try to double check both that and absence of leaks please? :-)

Comment 6

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29a30f4e9ad5

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/29a30f4e9ad5

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

Does this have or could have any unit (or other kind of) tests?