Closed Bug 931996 Opened 7 years ago Closed 7 years ago

Add an AppendEllipseToPath helper to Moz2D

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

This code is cribbed from gfxContext::Ellipse.
Attached patch patchSplinter Review
Attachment #823522 - Flags: review?(bas)
Blocks: 703159
Attachment #823522 - Flags: review?(bas) → review+
(In reply to Ed Morley [:edmorley UTC+1] from comment #4)
> Either this or bug 931915 also resulted in leaks, eg:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=29974755&tree=Mozilla-
> Inbound
> https://tbpl.mozilla.org/php/getParsedLog.php?id=29973338&tree=Mozilla-
> Inbound
> https://tbpl.mozilla.org/php/getParsedLog.php?id=29974475&tree=Mozilla-
> Inbound

In fact, I think these leaks were bug 926128 (multiple overlapping bustage). Once the compilation failures are fixed - can you run past try to double check both that and absence of leaks please? :-)
Blocks: 932761
https://hg.mozilla.org/mozilla-central/rev/29a30f4e9ad5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Does this have or could have any unit (or other kind of) tests?
Flags: in-testsuite?
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.