Ship branding favicon inside Android resources

NEW
Unassigned

Status

()

Firefox for Android
Favicon Handling
4 years ago
4 years ago

People

(Reporter: rnewman, Unassigned)

Tracking

(Blocks: 1 bug)

27 Branch
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
We load

jar:jar:file:///data/app/org.mozilla.fennec_rnewman-1.apk!/assets/omni.ja!/chrome/chrome/content/branding/favicon64.png

from the JAR on startup. Then we write it into the DB, from which we load it every time we start.

We should be doing something smarter, like loading it from resources.
Sigh.  Until Bug 928151 lands, this is going to be ugly.  But:

Add the favicon{32,64}.png files to ANDROID_GENERATED_RESFILES in m/a/b/moz.build.  Duplicate the icon .png logic in Makefile.in to install the files from branding into $OBJDIR/m/a/b/res.  Hate yourself.
(Reporter)

Comment 2

4 years ago
Note that on a shitty Moto RAZR XT910 with Android 2.3, fetching the icon from the JAR takes 4msec. Loading from resources is unlikely to be a giant win…
(Reporter)

Updated

4 years ago
Blocks: 999920
Component: General → Favicon Handling
You need to log in before you can comment on or make changes to this bug.