Closed
Bug 932035
Opened 11 years ago
Closed 11 years ago
Use slicker buttons for the mail reader header.
Categories
(Thunderbird :: Theme, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 28.0
People
(Reporter: jsbruner, Assigned: jsbruner)
Details
Attachments
(2 files, 1 obsolete file)
|
6.59 KB,
image/png
|
Details | |
|
1.35 KB,
patch
|
Paenglab
:
review+
Paenglab
:
ui-review+
|
Details | Diff | Splinter Review |
New Apperance
The current styling on OS X for the reply, forward, archive, etc buttons in the mail reader header could be improved. This bug should improve their visual appearance.
|
Assignee | |
Comment 1•11 years ago
|
||
This switches to a more transparent and flatter background that fades in on hover. I'll upload a screenshot for ui-review...
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #823582 -
Flags: ui-review?(richard.marti)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 823582 [details]
New Apperance
I see no changed icons, only changed buttons ;)
The buttons are looking smoother with your patch. When I click the smart reply button's dropdown arrow and now leave the button and the popup menu the button becomes the lighter not hovered background color. The button should still have the hovered background color. See also the Emoticon button in Write window.
You could add to .toolbarbutton-1.msgHeaderView-button:hover a .toolbarbutton-1.msgHeaderView-button[type="menu-button"][open]
I'll give a ui-r- now.
Attachment #823582 -
Flags: ui-review?(richard.marti) → ui-review-
|
|
Assignee | |
Comment 4•11 years ago
|
||
Ha. Yeah, guess I should wake up. This bug changes the appearance to the buttons, not the icons. Fail moment I guess. :) Anyway, this patch addresses your feedback. Resetting review and ui-review flags.
Attachment #823580 -
Attachment is obsolete: true
Attachment #823580 -
Flags: review?(richard.marti)
Attachment #823982 -
Flags: ui-review?(richard.marti)
Attachment #823982 -
Flags: review?(richard.marti)
|
|
Assignee | |
Updated•11 years ago
|
Summary: Use slicker icons for the mail reader header. → Use slicker buttons for the mail reader header.
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 823582 [details]
New Apperance
Moving the ui-review flag over to the patch...
Attachment #823582 -
Flags: ui-review-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #823582 -
Attachment description: New Apperance (for ui-review) → New Apperance
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 823982 [details] [diff] [review] Patch. Review of attachment 823982 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, looks good r+ui-r=me
Attachment #823982 -
Flags: ui-review?(richard.marti)
Attachment #823982 -
Flags: ui-review+
Attachment #823982 -
Flags: review?(richard.marti)
Attachment #823982 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/25b79fb93d64
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
You need to log in
before you can comment on or make changes to this bug.
Description
•