932054 - GeckoTopSites aborts thumbnail load; decode failed - OOM on decodeByteArray in E/GeckoBitmapUtils(16259): at org.mozilla.gecko.home.TopSitesPage$ThumbnailsLoader.loadInBackground(TopSitesPage.java:694)

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Aaron Train [:aaronmt]]

E/GeckoBitmapUtils(16259): decodeByteArray(bytes.length=428543, options= null) OOM!
E/GeckoBitmapUtils(16259): java.lang.OutOfMemoryError
E/GeckoBitmapUtils(16259): 	at android.graphics.BitmapFactory.nativeDecodeByteArray(Native Method)
E/GeckoBitmapUtils(16259): 	at android.graphics.BitmapFactory.decodeByteArray(BitmapFactory.java:441)
E/GeckoBitmapUtils(16259): 	at org.mozilla.gecko.gfx.BitmapUtils.decodeByteArray(BitmapUtils.java:122)
E/GeckoBitmapUtils(16259): 	at org.mozilla.gecko.gfx.BitmapUtils.decodeByteArray(BitmapUtils.java:111)
E/GeckoBitmapUtils(16259): 	at org.mozilla.gecko.home.TopSitesPage$ThumbnailsLoader.loadInBackground(TopSitesPage.java:694)
E/GeckoBitmapUtils(16259): 	at org.mozilla.gecko.home.TopSitesPage$ThumbnailsLoader.loadInBackground(TopSitesPage.java:656)
E/GeckoBitmapUtils(16259): 	at android.support.v4.content.AsyncTaskLoader.onLoadInBackground(AsyncTaskLoader.java:242)
E/GeckoBitmapUtils(16259): 	at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:51)
E/GeckoBitmapUtils(16259): 	at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:40)
E/GeckoBitmapUtils(16259): 	at android.support.v4.content.ModernAsyncTask$2.call(ModernAsyncTask.java:123)
E/GeckoBitmapUtils(16259): 	at java.util.concurrent.FutureTask.run(FutureTask.java:234)
E/GeckoBitmapUtils(16259): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
E/GeckoBitmapUtils(16259): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
E/GeckoBitmapUtils(16259): 	at java.lang.Thread.run(Thread.java:841)
W/GeckoTopSitesPage(16259): Aborting thumbnail load; decode failed.

Open 20 tabs; see no screenshots get decoded for the open sites when you visit about:home.

Expected: Screenshots from the site as thumbnails
Actual: Favicons only in the thumbnail spots

--
Nightly (10/28), Samsung Galaxy SIV (Android 4.3)

Comment 1

[Aaron Train [:aaronmt]]

Attachment: logcat

Comment 2

[Lucas Rocha (:lucasr)]

This might just be that we're keeping too many large bitmaps in memory when you have many tabs open.

Comment 3

[Lucas Rocha (:lucasr)]

Is this a regression?

Comment 4

[Aaron Train [:aaronmt]]

Yes, starting in 26. I'm unable to reproduce on 25.

Comment 5

[Richard Newman [:rnewman]]

Given that Bug 919768 improved matters in 26, this sounds like it's a sibling of Bug 931843 -- simply, we don't have enough memory to do all the bitmap-intensive stuff that we're doing due to a leak or bloat elsewhere. That's probably still bitmap-related, but we'll have to do some heap profiling to figure this out.

Comment 6

[Richard Newman [:rnewman]]

Aaron, give this a shot?

http://people.mozilla.org/~rnewman/thumbnails.apk

Comment 7

[Aaron Train [:aaronmt]]

Tried it out and its an improvement for me. I am not seeing the OutOfMemoryErrors on load. On a fresh profile, after 20 tabs open are open I get about 4/6 thumbnails shown whereas prior, I would get 0/6 shown - is this still a problem?

For what it's worth, all I was doing is: https://gist.github.com/AaronMT/7271240 on a new profile and watching Gecko output and then after a run, checking about:home in a new tab

Comment 8

[Richard Newman [:rnewman]]

Gonna mark this as dependent on Bug 931843, because the fixes in that bug should solve this, too.

Comment 9

[Aaron Train [:aaronmt]]

Fixed via patches in marked dependancy (tested via Nightly 11/05).