932060 - Whitelist annotation "BIOS_Manufacturer"

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[(Away)]

In bug 921609 I added an annotation called "BIOS_Manufacturer". Can we put this on the whitelist to make it available on the crash reports UI?

Comment 1

[Peter Bengtsson [:peterbe]]

I can certainly add it to the API [1] but we don't really have another whitelist for any other UI. All other things are are more or less hardcoded in the templates. 

Somewhere in the jungle of bugzilla we have a bug that will change the report index page to have two tables (in two separate sub-tabs) of 1) All primary main data 2) A complete list of all (allowed to see) keys and values from the raw crash. 

Can't find that bug right now but I'll search for it. 

[1] https://crash-stats.mozilla.com/api/

Comment 2

[Peter Bengtsson [:peterbe]]

https://bugzilla.mozilla.org/show_bug.cgi?id=908469 is the bug that will make the full raw crash available on the individual crash report page. 

So, can you wait till https://bugzilla.mozilla.org/show_bug.cgi?id=908469 gets implemented (could be weeks or months realistically) or shall we go ahead with just doing the API whitelisting inclusion for now?

Comment 3

[(Away)]

This is for the AMD CPU investigation, so I'd prefer not to wait weeks/months.

Comment 4

[Peter Bengtsson [:peterbe]]

I can whitelist it and it will be available on the API and on the report list page (if you know the signature).

Comment 5

[Peter Bengtsson [:peterbe]]

Attachment: Github PR

Comment 6

[Peter Bengtsson [:peterbe]]

I think, even after landing that pull request, we'll close this bug and keep our hopes and focus on https://bugzilla.mozilla.org/show_bug.cgi?id=908469 for a more pleasant way of accessing raw crash data on an individual crash report index page.

Comment 7

[Robert Kaiser]

We should do the same here that we did with bug 920439.

Comment 8

[Peter Bengtsson [:peterbe]]

(In reply to Robert Kaiser (:[e-mail]) from comment #7)
> We should do the same here that we did with bug 920439.

That's what I did in https://github.com/mozilla/socorro/pull/1625

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/81b7eb73de22df8b4bf4dabf1be449603a53cd51
fixes bug 932060 - Whitelist annotation "BIOS_Manufacturer", r=selenamarie

Comment 10

[Matt Brandt [:mbrandt]]

Bumping to verified as [qa-]. Please mark as [qa+] if you would like qa to test and verify this feature.