Closed Bug 932088 Opened 7 years ago Closed 7 years ago

mozmill bustage due to string removed from about:support

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(thunderbird27 fixed)

RESOLVED FIXED
Thunderbird 28.0
Tracking Status
thunderbird27 --- fixed

People

(Reporter: aryx, Assigned: aryx)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch, v1 (obsolete) — Splinter Review
This patch brings back the entity missing at the moment in about:support.
Attachment #823651 - Flags: review?(mbanner)
Comment on attachment 823651 [details] [diff] [review]
patch, v1

I think it would be nice to pick up all of bug 765285.

However, if we want to do that later and just pick up the bustage for now, but I think we should change the entity in the xhtml to be aboutSupport.crashes.title rather than aboutSupport.appBasicsCrashIDs as this allows localisers to use the already localised toolkit string rather than a duplicate.
Attachment #823651 - Flags: review?(mbanner) → review-
Attached patch patch, v2Splinter Review
Attachment #823651 - Attachment is obsolete: true
Attachment #823845 - Flags: review?(mbanner)
Comment on attachment 823845 [details] [diff] [review]
patch, v2

That's better, thanks. I'll get this landed.
Attachment #823845 - Flags: review?(mbanner) → review+
Comment on attachment 823845 [details] [diff] [review]
patch, v2

[Triage Comment]
That fixed it, hence getting onto aurora as well as merges were yesterday.
Attachment #823845 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/2a50fe892e2f
Assignee: nobody → archaeopteryx
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
You need to log in before you can comment on or make changes to this bug.