932091 - Convert SVGBBox.mBBox to Moz2D

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0777ab1c31a7

I tweaked a test. The patch caused a single test failure on Android because of a small rounding difference:

ERROR TEST-UNEXPECTED-FAIL | /tests/content/svg/content/test/test_bbox.xhtml | b.getBBox().width - got 9.166666984558105, expected 9.166667938232422

In other words the width (only) of the bbox for these two <text> elements is slightly different:

  <text id="b" x="20" y="20">b</text>
  <text id="tspan">
    <tspan x="20" y="20">b</tspan>
  </text>

This is due to extra switching between double and float (by using Rect, SVGBBox is now using float) as GetBBoxContribution works its way up the tree.

This should go away once we've finished the conversion to Moz2D and eliminated the gfx* classes from the SVG code. For now I've added a fuzz factor for that one test and I'll file a bug on removing that once the the Moz2D conversion is done.

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to Jonathan Watt [:jwatt] from comment #2)
> I'll file a bug on removing that once the the Moz2D conversion is done.

Bug 933707.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0777ab1c31a7