93212 - find button in history sidebar (like in bookmarks sidebar)

Status: RESOLVED WONTFIX

(Core Graveyard :: History: Global, enhancement)

Description

[Martin Macok]

There is a "Find" button in Bookmarks sidebar which searches through bookmarks.

It would be nice to have this button also in History sidebar to search through
history. I know there is a "Tasks/Tools/History" but I think the button in
History sidebar is a good thing.

Comment 1

[Alec Flett]

argh.. take two at reassigning history bugs to new owner

Comment 2

[Stefan Borggraefe]

Attachment: Patch

Adds a "Search..." button like in the Bookmarks sidebar and also a "History
Window" button that opens the stand-alone History window. The second button is
meant to be analogue to the "Manage" button in the Bookmarks sidebar.

Comment 3

[Stefan Borggraefe]

Comment on attachment 157326 [details] [diff] [review]
Patch

Neil, what do you think?

Comment 4

[[e-mail]]

Doesn't navigator.js already have a function to open the history window?
I think you should be able to access it using top.toHistory();

Comment 5

[Stefan Borggraefe]

Attachment: Patch V2

Updated patch.

Neil was correct, that navigator.js contains a function to open the History
window already. However this function wasn't reachable from the History
Sidebar. This didn't even work when I included navigator.js into
history-panel.xul, because then the function toOpenWindowByType() wasn't
available from there.

So I decided to move toHistory() to tasksOverlay.js where toOpenWindowByType()
is already contained and to include this file into the History Sidebar. Now the
code to open the History window is reachable from all its users and doesn't
need to be duplicated.

Furthermore I did the same with the code that opens the Bookmarks Manager. For
the Bookmarks Manager there were already two funtions for opening it. One of
them, manageBookmarks(), caused bug 203400 which is fixed by this new patch,
too.

Comment 6

[Stefan Borggraefe]

Comment on attachment 157610 [details] [diff] [review]
Patch V2

Neil, see my explanation in comment 5.

Comment 7

[Stefan Borggraefe]

Attachment: Patch V2.1 [See comment 9]

Fixed some minor bitrot.

Comment 8

[(mostly gone) XtC4UaLL [:xtc4uall]]

is this now INVALID since introduction of places + since there's a search field now?

Comment 9

[[e-mail]]

Certainly the history portions are now unnecessary but the bookmarks portions are still needed to fix bug 203400. I'll post an unbitrotted patch there.