Closed
Bug 932170
Opened 11 years ago
Closed 11 years ago
Add moz.build variables for generated sources
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
5.18 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
This also moves back what i had to move in bug 930380.
Attachment #823790 -
Flags: review?(gps)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Adding generated sources to garbage.
Attachment #823804 -
Flags: review?(gps)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #823790 -
Attachment is obsolete: true
Attachment #823790 -
Flags: review?(gps)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 823804 [details] [diff] [review]
Add moz.build variables for generated sources
Review of attachment 823804 [details] [diff] [review]:
-----------------------------------------------------------------
Reluctant r+.
I'd prefer we capture the generation rules as we move these things to moz.build so we don't fragment the build config. But that's a lot of work and likely slows down other Q4 goals. So I concede this is a necessary evil.
Attachment #823804 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•