Add moz.build variables for generated sources

RESOLVED FIXED in mozilla28

Status

RESOLVED FIXED
5 years ago
8 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla28
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 823790 [details] [diff] [review]
Add moz.build variables for generated sources

This also moves back what i had to move in bug 930380.
Attachment #823790 - Flags: review?(gps)
(Assignee)

Comment 2

5 years ago
Created attachment 823804 [details] [diff] [review]
Add moz.build variables for generated sources

Adding generated sources to garbage.
Attachment #823804 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Attachment #823790 - Attachment is obsolete: true
Attachment #823790 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Blocks: 932197

Comment 3

5 years ago
Comment on attachment 823804 [details] [diff] [review]
Add moz.build variables for generated sources

Review of attachment 823804 [details] [diff] [review]:
-----------------------------------------------------------------

Reluctant r+.

I'd prefer we capture the generation rules as we move these things to moz.build so we don't fragment the build config. But that's a lot of work and likely slows down other Q4 goals. So I concede this is a necessary evil.
Attachment #823804 - Flags: review?(gps) → review+

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d035b54ce1a3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Depends on: 962386

Updated

5 years ago
Whiteboard: [qa-]

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.