932198 - Convert nsSVGPatternFrame from using gfxASurface to using Moz2D APIs

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch [r=longsonr in bug 931769]

This patch can't land just yet until filters are converted to use a Moz2D backed temporary draw target. Without that these two test fail:

layout/reftests/svg/filters/filter-patterned-rect-01.svg
layout/reftests/svg/filters/filter-patterned-rect-02.svg

layout/reftests/svg/filters/filter-patterned-rect-01.svg
layout/reftests/svg/filters/filter-patterned-rect-02.svg

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 823879 [details] [diff] [review]
patch [r=longsonr in bug 931769]

https://hg.mozilla.org/integration/mozilla-inbound/rev/617e3d552045

The filter code is now only propagating Thebes backed gfxContexts rather than creating them, so I've landed this now. I had to fuzz a couple of the font tests.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/617e3d552045

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 823879 [details] [diff] [review]
patch [r=longsonr in bug 931769]

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 994081
User impact if declined: Certain SVG images fail to render completely on all platforms. See bug 1025652 .
Testing completed (on m-c, etc.): Tested on B2G, landed on m-c.
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch: None

Comment 7

[Jonathan Watt [:jwatt]]

(In reply to Michael Wu [:mwu] from comment #5)
> Risk to taking this patch (and alternatives if risky): 

There's probably less likely to be SVG breakage taking this patch than not, no I agree we should.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 823879 [details] [diff] [review]
patch [r=longsonr in bug 931769]

Aurora approval granted.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c2830085b9e9