932201 - [B2G][DSDS] Gecko needs to properly download MMS for non-active SIM

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect, P1)

Description

[Gene Lian (I already quit Mozilla)]

This bug is specifically for Gecko part, which blocks bug 918558 (V1.3 user story).

Please see bug 918558, comment #6. We need to do:

1. When the MMS downloading mode is "automatic", for the non-active SIM, Gecko has to download the MMS as if "manual" mode.

2. When the user wants to manually download an MMS (by taping on the download button) that came from the non-active SIM, Gecko has to return an error code like "NonActiveSimCardError" to notify Gaia.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Comment 2

[Gene Lian (I already quit Mozilla)]

Note that this patch depends on bug 854326.

Comment 3

[Gene Lian (I already quit Mozilla)]

Comment on attachment 823904 [details] [diff] [review]
Patch

Review of attachment 823904 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/src/gonk/MmsService.js
@@ +1636,5 @@
>      }
>  
> +    // Under the "automatic" retrieval mode, for the non-active SIM, we have to
> +    // download the MMS as if it is "manual" retrieval mode.
> +    if (retrievalMode == RETRIEVAL_MODE_AUTOMATIC &&

Should be:

(retrievalMode == RETRIEVAL_MODE_AUTOMATIC || retrievalMode == RETRIEVAL_MODE_AUTOMATIC_HOME)

Comment 4

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V2

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

1.3+ for blocking 1.3 committed user story

Comment 6

[Gene Lian (I already quit Mozilla)]

Ping for review? :)

Comment 7

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 824527 [details] [diff] [review]
Patch, V2

Review of attachment 824527 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 8

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V2.1

r=ctai,vicamo

Comment 9

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/b2g-inbound/rev/a6b599783f70

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a6b599783f70