[keyboard] previous InputMethod will not disappear while switching different keyboard app(3rd party keyboard) and input type.

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: GaryChen, Assigned: GaryChen)

Tracking

unspecified
x86
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 fixed)

Details

(Whiteboard: [3rd-party-keyboard])

Attachments

(3 attachments)

Created attachment 823957 [details]
螢幕快照 2013-10-29 下午8.34.01.png

make sure you have 3rd-party keyboard, you can install from test_apps.
https://github.com/mozilla-b2g/gaia/tree/master/test_apps/test-keyboard-app
STR:
  1. launch settings app
  2. enable 'gaia test-app' 'English'
  3. launch contact app
  4. click '+' to add new contact
  5. click 'Last Name' field
  6. press global icon to switch to 'gaia test-app' 'English'
  7. click 'Phone' field

  expect:
    'gaia test-app English' will hidden

  actually:
    'number' and 'gaia test-app:English' are shown.
Assignee: nobody → gchen
blocking-b2g: --- → hd?
Comment on attachment 823962 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/13179

r=me.

Mind to add some tests to this? :)
Attachment #823962 - Flags: review?(rlu) → review+
** For Triage **
This is an obvious UI issue, so nominate it as koi+.
Status: NEW → ASSIGNED
blocking-b2g: hd? → koi?

Updated

5 years ago
blocking-b2g: koi? → koi+
Hi Rudy,
   I've add some unit test, please help to take a look thanks.
   https://github.com/mozilla-b2g/gaia/pull/13179/files
Flags: needinfo?(rlu)
Thanks for taking care of tests as well.
r+++ from me. :)
Flags: needinfo?(rlu)
Travis passed
https://travis-ci.org/mozilla-b2g/gaia/builds/13272220

merged in gaia master
https://github.com/mozilla-b2g/gaia/commit/d59c9446595eba2677fdcb363b2b42ae52ee0b12
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
status-b2g-v1.2: --- → affected
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 d59c9446595eba2677fdcb363b2b42ae52ee0b12
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(gchen)
Since bug #912010 has been backout on v1.2, so this patch need to wait for it re-land again.
Thanks John Ford.
Flags: needinfo?(gchen)
Whiteboard: [3rd-party-keyboard]

Comment 10

5 years ago
Hi, Gary,

Thanks for your help and bug submission!
I verified this patch.

Attaching the screenshot.

* Test Build:
 - Gaia:     2140c987fdde1c99097018f7e93b0bbd43d2125d
 - Gecko:    http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/6a831fcb96f4
 - BuildID   20131106004004
 - Version   26.0
Status: RESOLVED → VERIFIED

Comment 11

5 years ago
Created attachment 828074 [details]
Number Keyboard on contacts app
You need to log in before you can comment on or make changes to this bug.