These items were mentioned after the initial merge of the new advanced search: * Regroup fields * Maybe align labels right so they don't stray far from their fields on wide viewports * Show submit button The only one I have a question on is 'numero uno'. Has it been decided what the order (grouping) of the fields should be?
At the time, I think I had in mind grouping the fields as fn/fn-ref, macro/macro-ref, etc. But, with fresh eyes, I like what you've done better: putting the most frequently used fields up top. That means less tabbing for the majority of uses, and the fields are still few enough to scan quickly for odd cases. Let's stick with that for starters. (The "Even Further" heading even serves to visually chunk the fields. Even if there were no meaningful distinction between the upper and lower ones, it would still make the sum more scannable. Nice work.)
Pull request https://github.com/mozilla/dxr/pull/171 merged.
Commits pushed to master at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/03da86a64cf2055135d966d05629df5114643821 Fix Bug 932264, minor tweaks to advanced search UI https://github.com/mozilla/dxr/commit/6a8c8c11c02a505891a2858d2f95025556bac4b4 Merge pull request #171 from ossreleasefeed/bug932264-minor-enhancements-to-as Fix Bug 932264, minor tweaks to advanced search UI