Use Moz2D size classes in ipdl

NEW
Unassigned

Status

()

Core
General
4 years ago
4 years ago

People

(Reporter: dzbarsky, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Updated

4 years ago
Attachment #823983 - Attachment is patch: true
Attachment #823983 - Attachment mime type: message/rfc822 → text/plain
Attachment #823983 - Flags: review?(nical.bugzilla)
David, can you put the comments into the bug as to why we're doing this? I'm not suggesting we don't have a good reason, just that we should write it down so that it's obvious a few years from now.  Thanks.

Updated

4 years ago
Attachment #823983 - Flags: review?(nical.bugzilla) → review+
(Reporter)

Comment 2

4 years ago
(In reply to Milan Sreckovic [:milan] from comment #1)
> David, can you put the comments into the bug as to why we're doing this? I'm
> not suggesting we don't have a good reason, just that we should write it
> down so that it's obvious a few years from now.  Thanks.

We want to transition away from using nsIntSize and gfxIntSize and instead use gfx::IntSize or more specific size classes (like ScreenIntSize) when possible.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bad6c063b01f
Hmm, the non-Windows, non-b2g-desktop-Windows failures actually parsed out an error: https://tbpl.mozilla.org/php/getParsedLog.php?id=30098888&tree=Mozilla-Inbound

../../../gecko/gfx/layers/ipc/ShadowLayerUtilsGralloc.cpp:497: error: conversion from 'const mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits>' to non-scalar type 'gfxIntSize' requested
../../../gecko/gfx/layers/ipc/ShadowLayerUtilsGralloc.cpp:535: error: no match for 'operator=' in '* aSize = ((const mozilla::layers::SurfaceDescriptorGralloc*)((const mozilla::layers::SurfaceDescriptor*)aDescriptor)->mozilla::layers::SurfaceDescriptor::get_SurfaceDescriptorGralloc())->mozilla::layers::SurfaceDescriptorGralloc::size()'
make[6]: *** [ShadowLayerUtilsGralloc.o] Error 1
make[5]: *** [gfx/layers/compile] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [realbuild] Error 2
make[1]: *** [build] Error 2
make: *** [out/target/product/generic/obj/DATA/gecko_intermediates/gecko] Error 2
Return code: 2
failed to build
You need to log in before you can comment on or make changes to this bug.