932280 - [Qt] Reference to a file that doesn't exist in SOURCES (src/base/moc_message_pump_qt.cc)

Status: RESOLVED INCOMPLETE

Description

[Oleg Romashin (:romaxa)]

Widget Qt build failed due to failed file existence check for auto generated moc_* files.

File "mozilla-central/python/mozbuild/mozbuild/frontend/emitter.py", line 137, in emit_from_sandbox
    % (symbol, src, sandbox['RELATIVEDIR']))
mozbuild.frontend.reader.SandboxValidationError: Reference to a file that doesn't exist in SOURCES (src/base/moc_message_pump_qt.cc) in ipc/chromium
*** Fix above errors and then restart with               "make -f client.mk build"
make[2]: *** [configure] Error 1

Comment 1

[Oleg Romashin (:romaxa)]

Created attachment 823999 [details] [diff] [review]
qt_build_fix.diff

Quick fix by moving moc files into Makefile.in

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 823999 [details] [diff] [review]
qt_build_fix.diff

Review of attachment 823999 [details] [diff] [review]:
-----------------------------------------------------------------

> Bug 932280 - [Qt] Reference to a file that doesn't exist in SOURCES (src/base/moc_message_pump_qt.cc). r=Ms2ger

Might want to make the commit message clearer.

This looks good to me, but I'd rather have a build peer sign off.

::: widget/qt/faststartupqt/Makefile.in
@@ +14,5 @@
> +CPPSRCS += \
> +	moc_moziqwidget.cpp \
> +	moc_nsFastStartupQt.cpp \
> +	mozqglwidgetwrapper.cpp \
> +	nsQAppInstance.cpp \

For these last two, I think you can fix the path in the moz.build and gte rid of the installing

Comment 3

[Ted Mielczarek [:ted] [:ted.mielczarek]]

Comment on attachment 823999 [details] [diff] [review]
qt_build_fix.diff

Review of attachment 823999 [details] [diff] [review]:
-----------------------------------------------------------------

Do we have a plan to get the moc_*cpp sources working in moz.build?

Comment 4

[Oleg Romashin (:romaxa)]

Created attachment 824020 [details] [diff] [review]
attachment.cgi?id=823999

Comment 5

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a21dc77dad9

Comment 6

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> Do we have a plan to get the moc_*cpp sources working in moz.build?

bug 932197

Comment 7

[Wes Kocher (:KWierso)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/6c06b499bb16 for inexplicably breaking mochitest-browser-chrome on Win7Debug like this: https://tbpl.mozilla.org/php/getParsedLog.php?id=29851737&tree=Mozilla-Inbound

Comment 8

[Wes Kocher (:KWierso)]

(In reply to Wes Kocher (:KWierso) from comment #7)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/6c06b499bb16 for
> inexplicably breaking mochitest-browser-chrome on Win7Debug like this:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=29851737&tree=Mozilla-
> Inbound

Still failing on the backout, so this can reland once the tree reopens.

Comment 9

[Mike Hommey [:glandium]]

(In reply to Wes Kocher (:KWierso) from comment #8)
> Still failing on the backout, so this can reland once the tree reopens.

Actually, I'd rather land bug 932197 first. That should make this patch mostly obsolete (besides the whitespace fix)

Comment 10

[Benjamin Smedberg]

In bug 1282866, I have removed the QT code from the Firefox tree with the approval of the active peer. That code is not currently maintained by any team.

I have looked through the bugs in the Widget: Qt bugzilla component and I believe all of these are no longer relevant because the Qt code has been removed. If you believe that this bug is still valid, please move it to another more appropriate bugzilla component as you reopen it.