Closed Bug 932280 Opened 6 years ago Closed 4 years ago

[Qt] Reference to a file that doesn't exist in SOURCES (src/base/moc_message_pump_qt.cc)

Categories

(Core Graveyard :: Widget: Qt, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(1 file, 1 obsolete file)

Widget Qt build failed due to failed file existence check for auto generated moc_* files.

File "mozilla-central/python/mozbuild/mozbuild/frontend/emitter.py", line 137, in emit_from_sandbox
    % (symbol, src, sandbox['RELATIVEDIR']))
mozbuild.frontend.reader.SandboxValidationError: Reference to a file that doesn't exist in SOURCES (src/base/moc_message_pump_qt.cc) in ipc/chromium
*** Fix above errors and then restart with               "make -f client.mk build"
make[2]: *** [configure] Error 1
Attached patch qt_build_fix.diff (obsolete) — Splinter Review
Quick fix by moving moc files into Makefile.in
Attachment #823999 - Flags: review?(Ms2ger)
Comment on attachment 823999 [details] [diff] [review]
qt_build_fix.diff

Review of attachment 823999 [details] [diff] [review]:
-----------------------------------------------------------------

> Bug 932280 - [Qt] Reference to a file that doesn't exist in SOURCES (src/base/moc_message_pump_qt.cc). r=Ms2ger

Might want to make the commit message clearer.

This looks good to me, but I'd rather have a build peer sign off.

::: widget/qt/faststartupqt/Makefile.in
@@ +14,5 @@
> +CPPSRCS += \
> +	moc_moziqwidget.cpp \
> +	moc_nsFastStartupQt.cpp \
> +	mozqglwidgetwrapper.cpp \
> +	nsQAppInstance.cpp \

For these last two, I think you can fix the path in the moz.build and gte rid of the installing
Attachment #823999 - Flags: review?(Ms2ger) → review?(ted)
Comment on attachment 823999 [details] [diff] [review]
qt_build_fix.diff

Review of attachment 823999 [details] [diff] [review]:
-----------------------------------------------------------------

Do we have a plan to get the moc_*cpp sources working in moz.build?
Attachment #823999 - Flags: review?(ted) → review+
Attachment #823999 - Attachment is obsolete: true
Attachment #824020 - Flags: review?(ted)
Attachment #824020 - Flags: review?(ted) → review+
Assignee: nobody → romaxa
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> Do we have a plan to get the moc_*cpp sources working in moz.build?

bug 932197
(In reply to Wes Kocher (:KWierso) from comment #7)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/6c06b499bb16 for
> inexplicably breaking mochitest-browser-chrome on Win7Debug like this:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=29851737&tree=Mozilla-
> Inbound

Still failing on the backout, so this can reland once the tree reopens.
(In reply to Wes Kocher (:KWierso) from comment #8)
> Still failing on the backout, so this can reland once the tree reopens.

Actually, I'd rather land bug 932197 first. That should make this patch mostly obsolete (besides the whitespace fix)
In bug 1282866, I have removed the QT code from the Firefox tree with the approval of the active peer. That code is not currently maintained by any team.

I have looked through the bugs in the Widget: Qt bugzilla component and I believe all of these are no longer relevant because the Qt code has been removed. If you believe that this bug is still valid, please move it to another more appropriate bugzilla component as you reopen it.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.