Closed Bug 932305 Opened 11 years ago Closed 11 years ago

The Cmd-D shortcut no longer works

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox26 unaffected, firefox27 fixed, firefox28 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 28
Tracking Flags:
Tracking Status
firefox26 --- unaffected
firefox27 --- fixed
firefox28 --- fixed

People

(Reporter: past, Assigned: vporof)

References

Details

(Keywords: regression, Whiteboard: [good first verify])

Attachments

(1 file)

dbg-cmd-d.patch
2.08 KB, patch
past
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Before the CodeMirror integration Cmd-D used to focus the search bar and prepend the '@' character to search for a function definition. It looks like bug 919709 broke it.
Attached patch dbg-cmd-d.patch — — Splinter Review 
Need to uplift to aurora as well.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8338303 - Flags: review?(past)
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Attachment #8338303 - Flags: review?(past) → review+
Comment on attachment 8338303 [details] [diff] [review]
dbg-cmd-d.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 919709
User impact if declined: Users won't be able to easily search for functions in the debugger
Testing completed (on m-c, etc.): locally, fx-team
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None
Attachment #8338303 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/e193c7a76f4f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Attachment #8338303 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Victor, does this have or need in-testsuite tests?
Flags: needinfo?(vporof)
Flags: in-testsuite?
Whiteboard: [good first verify]
This functionality has automated tests.
Flags: needinfo?(vporof)
(In reply to Victor Porof [:vp] from comment #7)
> This functionality has automated tests.

Did it have automated tests before this regressed? If so I think the reliability of said tests needs to be investigated.
Flags: in-testsuite? → in-testsuite+
The functionality itself has automated tests that work properly. However, there is not test that triggers the shortcut via a keyboard event (this particular bug).
(In reply to Victor Porof [:vp] from comment #9)
> The functionality itself has automated tests that work properly. However,
> there is not test that triggers the shortcut via a keyboard event (this
> particular bug).

Seems like something we could do in Mozmill. Henrik?
Flags: in-qa-testsuite?(hskupin)
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #10)
> (In reply to Victor Porof [:vp] from comment #9)
> > The functionality itself has automated tests that work properly. However,
> > there is not test that triggers the shortcut via a keyboard event (this
> > particular bug).
> 
> Seems like something we could do in Mozmill. Henrik?

I think this can be a browser-chrome test, unless it's localization dependent
Oh, totally a Mozmill test regarding the localization dependent request. Browser-chrome will only test en-US builds.
Flags: in-testsuite+ → in-testsuite-
Removing my name from in-qa-testsuite flag for a better query.
Flags: in-qa-testsuite?(hskupin) → in-qa-testsuite?
If a shortcut test is still wanted I would suggest that you file a bug in Testing:Firefox UI Tests.
Flags: in-qa-testsuite?
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: