Closed Bug 932315 Opened 6 years ago Closed 6 years ago

Throw a different error when this-unwrapping fails for security reasons

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: peterv, Assigned: peterv)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1Splinter Review
Currently we say the object doesn't implement the interface, which isn't really true.
Attachment #824027 - Flags: review?(bzbarsky)
Blocks: 932322
Comment on attachment 824027 [details] [diff] [review]
v1

> MSG_DEF(MSG_METHOD_THIS_UNWRAPPING_DENIED, 1, "Permission denied while unwrapping \"this\" object for calling '{0}'.")

How about "Permission to call '{0}' denied." for the message?  The fact that "unwrapping" in involved is an implementation detail...

>+MSG_DEF(MSG_GETTER_THIS_UNWRAPPING_DENIED, 1, "Permission denied while unwrapping \"this\" object for calling getter for '{0}'.")

"Permission to call '{0}' getter denied."

>+MSG_DEF(MSG_SETTER_THIS_UNWRAPPING_DENIED, 1, "Permission denied while unwrapping \"this\" object for calling setter for '{0}'.")

"Permission to call '{0}' setter denied.

r=me with those nits.
Attachment #824027 - Flags: review?(bzbarsky) → review+
Comment on attachment 824687 [details] [diff] [review]
Lazily allocate log buffers for webrtc (4MB saving)

Oops, typo on bug #
Attachment #824687 - Attachment is obsolete: true
either this patch or the patch on bug 932320 caused a large tp5o shutdown regression on windows xp: 
https://groups.google.com/forum/#!topic/mozilla.dev.tree-management/r9iehVDynmM
https://hg.mozilla.org/mozilla-central/rev/e790b3c30e1a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.