nav-bar is missing top border in private browsing windows on UX

RESOLVED FIXED in Firefox 28

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mconley, Assigned: Gijs)

Tracking

Trunk
Firefox 28
x86_64
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P2][Australis:M9])

Attachments

(1 attachment)

mart3ll reported this to me on IRC.

STR:

1) Open a PB window on OS X using the UX branch
2) Notice the missing border between the top of the nav-bar and the titlebar (see http://cl.ly/image/21363i0s2l0C)
Assignee

Comment 1

6 years ago
Oh boo. I guess in this case we need to draw the border ourselves still?
(In reply to :Gijs Kruitbosch from comment #1)
> Oh boo. I guess in this case we need to draw the border ourselves still?

Yeah, for private browsing windows - since we're not using the native titlebar gradient (which comes with its own bottom border).
Couldn't we use the native titlebar gradient in private browsing windows, too? I guess we're not using it because the private browsing marker in the top right corner is a background image on the window, and the title bar would cover it... can we make it a ::before on #titlebar, maybe?
Assignee

Comment 4

6 years ago
(In reply to Markus Stange [:mstange] from comment #3)
> Couldn't we use the native titlebar gradient in private browsing windows,
> too? I guess we're not using it because the private browsing marker in the
> top right corner is a background image on the window, and the title bar
> would cover it... can we make it a ::before on #titlebar, maybe?

We could, but that sounds like it'll introduce more bugs. I think we want to keep a custom design anyway, because in the future we'll have a completely different one (darker than the current one). Can we just take the changeset that removed it and reapply it in the private browsing case only? Sounds like it shouldn't be too bad.
Whiteboard: [Australis:P4][Australis:M?] → [Australis:P2][Australis:M?]
Assignee

Comment 5

6 years ago
It's also missing in customize mode.
Assignee

Comment 6

6 years ago
This should do it... :-)
Attachment #826189 - Flags: review?(mnoorenberghe+bmo)
Assignee

Updated

6 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #826189 - Flags: review?(mnoorenberghe+bmo) → review+
Comment on attachment 826189 [details] [diff] [review]
draw border for customize mode and fullscreen,

Please make the commit message more detailed to indicate which border you are talking about.
Assignee

Comment 8

6 years ago
https://hg.mozilla.org/projects/ux/rev/42461ce3dcd0
Updated commit msg: draw tabstoolbar bottom border ourselves during customize mode, private browsing mode and fullscreen
Whiteboard: [Australis:P2][Australis:M?] → [Australis:P2][Australis:M9][fixed-in-ux]
Assignee

Comment 9

6 years ago
https://hg.mozilla.org/mozilla-central/rev/42461ce3dcd0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][Australis:M9][fixed-in-ux] → [Australis:P2][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.