932344 - nav-bar is missing top border in private browsing windows on UX

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

mart3ll reported this to me on IRC.

STR:

1) Open a PB window on OS X using the UX branch
2) Notice the missing border between the top of the nav-bar and the titlebar (see http://cl.ly/image/21363i0s2l0C)

Comment 1

[:Gijs (he/him)]

Oh boo. I guess in this case we need to draw the border ourselves still?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

(In reply to :Gijs Kruitbosch from comment #1)
> Oh boo. I guess in this case we need to draw the border ourselves still?

Yeah, for private browsing windows - since we're not using the native titlebar gradient (which comes with its own bottom border).

Comment 3

[Markus Stange [:mstange]]

Couldn't we use the native titlebar gradient in private browsing windows, too? I guess we're not using it because the private browsing marker in the top right corner is a background image on the window, and the title bar would cover it... can we make it a ::before on #titlebar, maybe?

Comment 4

[:Gijs (he/him)]

(In reply to Markus Stange [:mstange] from comment #3)
> Couldn't we use the native titlebar gradient in private browsing windows,
> too? I guess we're not using it because the private browsing marker in the
> top right corner is a background image on the window, and the title bar
> would cover it... can we make it a ::before on #titlebar, maybe?

We could, but that sounds like it'll introduce more bugs. I think we want to keep a custom design anyway, because in the future we'll have a completely different one (darker than the current one). Can we just take the changeset that removed it and reapply it in the private browsing case only? Sounds like it shouldn't be too bad.

Comment 5

[:Gijs (he/him)]

It's also missing in customize mode.

Comment 6

[:Gijs (he/him)]

Attachment: draw border for customize mode and fullscreen,

This should do it... :-)

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 826189 [details] [diff] [review]
draw border for customize mode and fullscreen,

Please make the commit message more detailed to indicate which border you are talking about.

Comment 8

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/42461ce3dcd0
Updated commit msg: draw tabstoolbar bottom border ourselves during customize mode, private browsing mode and fullscreen

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/42461ce3dcd0