932379 - [B2G][Settings] There is no notification that changes will not be saved when the user attempts to change their ringtone with USB storage enabled.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[J Zimbrick]

Description:
There is no notification that the user is unable to save changes to Ringer or Alert tones when USB Storage is currently enabled. The user is able to enter the page to select the tone, but after selecting a tone and tapping the Done button, nothing will happen.

Repro Steps:
1. Update Buri device to 1.3 Mozilla build 20131029040205.
2. Open the Settings app.
3. Scroll down and tap the Enable USB storage slider to turn USB storage on.
4. Plug the device in to a computer via USB.
5. Scroll back up in the Settings menu and tap Sound to open the Sound menu.
6. Tap either the box under Ringer or Alerts.
7. Select "System Ringtones" if the "Select from:" prompt appears.
8. Pick any ringer or alert and press "Done" in the top right corner.
9. Observe that the only thing that happens after touching the "Done" button is that it turns blue, nothing else happens, and the ring tone is not saved.

Actual:
Pressing the done button after selecting a different ringtone with USB storage enabled does nothing.

Expected:
Either the user is able to select and save a new ringtone with USB storage enabled, OR a message similar to the ones that appear when opening the Camera, Gallery, or Music apps with USB storage enabled stating that the user must disconnect the device to make a change to these settings.

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131029040205
Gaia: 92c097fd7ac9886f937d9decb0e03ab673deaa1b
Gecko: 518f5bff0ae4
Version: 28.0a1
Base Image: 2013

Notes:

Repro frequency: 100%

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.1 & 1.2?

Comment 2

[J Zimbrick]

Actually working on a regression window now, it does not occur in the latest 1.1, does reproduce in the most recent build of 1.2. Does not happen in some earlier 1.2 builds I had saved.

Will update further when I've got a specific window done.

Comment 3

[J Zimbrick]

Regression window:

Last Working Build:
Device: Buri v1.2 Mozilla RIL
BuildID: 20130918004001
Gaia: 9b1b262e8fde58be453fb05ed91c0e93ab86d394
Gecko: 0322470077b7
Version: 26.0a2
Base Image: 20131015

First Broken Build:
Device: Buri v1.2 Mozilla RIL
BuildID: 20130920122927
Gaia: 7b6147372cbf560744a02be50e0a862a825caef6
Gecko: 0ff4dcd55258
Version: 26.0a2
Base Image: 20131015

Seems to coincide with the point where Ringers and Alerts were given separate dropdown menus, the working build has them all in one list, and the broken one has two separate lists.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Need to fix the regression unless the fix is non-trivial.

Comment 5

[David Flanagan [:djf]]

Ringtones do not use the sdcard. But the code for transferring ringtones via activities had a workaround in it that used the sdcard. I think that workaround caused this bug.

That workaround has been removed in bug 923544 which landed to master. So as soon as that is uplifted to v1.2, I think this bug will go away.

Comment 6

[David Flanagan [:djf]]

Okay I uplifted 923544.  

J Zimbrick: could you confirm that this fixes the bug, please?

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thank you!

Comment 8

[J Zimbrick]

This issue appears fixed in the latest Mozilla RIL 1.2 and 1.3 builds. When USB storage is on and the user attempts to change a Ringer or Alert tone, the done button now works as expected and the selected tone is saved.

Environmental Variables:
Device: Buri v1.2 Mozilla RIL
BuildID: 20131031004003
Gaia: df049e3177ced0ca493ff0d192c65f18392bb462
Gecko: 93eafd042c1c
Version: 26.0
Base Image: 20131015

&

Device: Buri v1.3 Mozilla RIL
BuildID: 20131030040204
Gaia: 162cc9cd7153dcb284e5f54d5598fb27f1ab18aa
Gecko: 829d7bef8b0a
Version: 28.0a1
Base Image: 20131015

Changing tracking flags, can we resolve/verify this as fixed?

Comment 9

[Nikolai Khristoforov]

Verified that the user is able to change their ringtone and alerts while USB Storage is enabled and the changes are saved.

Device: Buri v 1.2 Com RIL
BuildID: 20131111004004
Gaia: 670b2c8329bca6f142939185be71274166d82bb8
Gecko: 1ac147e4e2f0
Version: 26.0
Firmware Version: 20131104