932505 - Add some basic checking for Bindings.conf

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

See bug 932409 comment 2.

Comment 1

[Andrew McCreight [:mccr8]]

This is what I implemented:
1. If the entry is a list with a single element, it should have 'workers'=True. (This is just aesthetics.)
2. If the entry is a list with two elements, the 'workers' value for each should be different.
3. The entry should not be a list with more than two elements.

FYI, only 1, the trivial one, is violated.

If people have some more ideas, I can try to add them.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: add some checks and describe what the rules are

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 825571 [details] [diff] [review]
add some checks and describe what the rules are

>+                raise TypeError("Interface " + iface.identifier.name +
>+                                " should have no more than two entries")

  "... entries in Bindings.conf" 

perhaps?  r=me. Thank you for cleaning this up and the documentation!

Comment 5

[Andrew McCreight [:mccr8]]

Good point.  I added something about Bindings.conf to all of the error messages.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f39d5c1d8ea8

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f39d5c1d8ea8