932596 - mozmake build fails with objdir on a different drive

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

Attachment: patch from glandium

The mozmake build fails if my objdir is on a different drive from my srcdir (my standard config has the objdir on a ramdisk):

39:20.17 nsXPCOMGlue.cpp
39:22.35 Traceback (most recent call last):
39:22.35   File "c:\mozilla-build\python\Lib\runpy.py", line 162, in _run_module
_as_main
39:22.35     "__main__", fname, loader, pkg_name)
39:22.36   File "c:\mozilla-build\python\Lib\runpy.py", line 72, in _run_code
39:22.36     exec code in run_globals
39:22.36   File "c:\builds\git-mozilla-central\python\mozbuild\mozbuild\action\l
ink_deps.py", line 223, in <module>
39:22.36     main(sys.argv[1:])
39:22.36   File "c:\builds\git-mozilla-central\python\mozbuild\mozbuild\action\l
ink_deps.py", line 211, in main
39:22.36     abspaths=opts.abspaths)
39:22.36   File "c:\builds\git-mozilla-central\python\mozbuild\mozbuild\action\l
ink_deps.py", line 110, in __init__
39:22.36     mozpath.relpath(topsrcdir, os.curdir): topsrcdir_value,
39:22.36   File "c:\builds\git-mozilla-central\python\mozbuild\mozpack\path.py",
 line 27, in relpath
39:22.36     rel = normsep(os.path.relpath(path, start))
39:22.36   File "f:\git-mozilla-debug\_virtualenv\lib\ntpath.py", line 512, in r
elpath
39:22.36     % (path_prefix, start_prefix))
39:22.36 ValueError: path is on drive c:, start on drive f:
39:22.36 c:/builds/git-mozilla-central/config/recurse.mk:227: recipe for target
'libs' failed
39:22.36 mozmake.EXE[5]: *** [libs] Error 1
39:22.36 c:/builds/git-mozilla-central/config/recurse.mk:99: recipe for target '
config/libs' failed
39:22.36 mozmake.EXE[4]: *** [config/libs] Error 2
39:22.36 c:/builds/git-mozilla-central/config/recurse.mk:39: recipe for target '
libs' failed
39:22.37 mozmake.EXE[3]: *** [libs] Error 2
39:22.37 c:/builds/git-mozilla-central/config/rules.mk:631: recipe for target 'd
efault' failed
39:22.37 mozmake.EXE[2]: *** [default] Error 2
39:22.37 c:/builds/git-mozilla-central/client.mk:394: recipe for target 'realbui
ld' failed
39:22.37 mozmake.EXE[1]: *** [realbuild] Error 2
39:22.37 client.mk:179: recipe for target 'build' failed
39:22.37 mozmake.EXE: *** [build] Error 2
39:22.38 881 compiler warnings present.
2

Glandium had me try a patch which appears to help.

Comment 1

[Mike Hommey [:glandium]]

Do you go through an entire build with that patch? (Note it's not landable as is, it needs tweaking, but it's good enough for testing)

Comment 2

[Benjamin Smedberg]

oops, doesn't apply

Comment 3

[Mike Hommey [:glandium]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> oops, doesn't apply

It's also not landable, cf. comment 1. ;)

Comment 4

[Mike Hommey [:glandium]]

Attachment: Avoid link_deps error when srcdir and objdir are not on the same drive

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7d7744e05b1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f7d7744e05b1