Firefox 25 broke Previous and Next keyboard shortcuts in the Find bar

NEW
Unassigned

Status

()

P5
normal
5 years ago
3 years ago

People

(Reporter: shtetldik, Unassigned)

Tracking

({regression})

25 Branch
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131025151332

Steps to reproduce:

Upgraded from Firefox 24 to Firefox 25.


Actual results:

Previous and Next keyboard shortcuts in the search bar stopped working (Alt+P and Alt+N when the search bar is focused). Other shortcuts still work (Alt+A - Highlight All, Alt+C - Match Case).


Expected results:

Keyboard shortcuts should have worked as usual
(Reporter)

Updated

5 years ago
Component: Untriaged → Keyboard Navigation
(Reporter)

Updated

5 years ago
Summary: Firefox 25 broke Previous and Next keyboard shortcuts in the search bar → Firefox 25 broke Previous and Next keyboard shortcuts in the Find bar
(Reporter)

Comment 1

5 years ago
Apparently there are alternative shorctuts which still work and can be used as a workaround

Next: Ctrl+G
Previous: Ctrl+Shift+G

They aren't so natural as Alt+N and Alt+P though, and are harder to use.

Updated

5 years ago
Component: Keyboard Navigation → Find Toolbar
Keywords: regression
OS: Linux → All
Product: Firefox → Toolkit
Hardware: x86_64 → All

Updated

5 years ago
Duplicate of this bug: 933230

Updated

5 years ago
Duplicate of this bug: 933011
Please also read bug 933011 comment 932643 (and following comments) for alternative solutions.
I meant bug 933011 comment 1... I think my brain blew a fuse just there, sorry...

Comment 6

5 years ago
The other keys listed in bug 933011 are F3, Shift+F3 and Shift+Enter

However, the discoverability of all these shortcuts is null.

At least they should be listed in previous.tooltip and next.tooltip

I guess they come from:
> xbl:inherits="accesskey=findnextaccesskey"
> xbl:inherits="accesskey=findnextaccesskey"
(toolkit/content/widgets/findbar.xml)

although that's the only reference in the whole mozilla-central :(


Content I was going to file as a new bug before I found 52f8868edc1d:
When searching for text in a page it used to be possible to do that just with the keyboard. Ctrl+F, «text to search», Alt+<letter> for next/previous instance of the text, where <letter> was locale specific (accesskey on the text of the buttons).

Those next/previous buttons are now Up/Down arrows. The problem is that now there is no way to navigate just with the keyboard. Having to switch to the mouse in this case is a nuisance.

http://hg.mozilla.org/mozilla-central/rev/52f8868edc1d
On latest nightly: 48.0a1 20160314030215 Mozilla/5.0 (X11; Linux i686; rv:48.0) Gecko/20100101 Firefox/48.0,  I have the following shortcuts working for the find bar:
Next: Ctrl+G, F3
Previous: Ctrl+shift+G, Shift+F3

The issue that i indeed see here is that the next and the previous buttons do not show any tooltip that would state the shortcuts available. e.g. Menu/History/Show All History - Ctrl+Shift+H.

Note that a comparison for the same functionality in GoogleChrome does show the same lack of tooltip/label referring to the shortcuts available.

Therefore, changing the bug title to reflect this and also setting it to new.
Severity: normal → trivial
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Summary: Firefox 25 broke Previous and Next keyboard shortcuts in the Find bar → Previous and Next keyboard shortcuts in the Find bar are missing the shortcuts tooltips
Version: 25 Branch → Trunk
(In reply to Adrian Florinescu [:AdrianSV] from comment #7)
> The issue that i indeed see here is that the next and the previous buttons
> do not show any tooltip that would state the shortcuts available. e.g.
> Menu/History/Show All History - Ctrl+Shift+H.

No shortcuts were never shown in tooltips of any findbar buttons. That's a different enhancement that should be in a new bug (don't know off-hand if there's one already), set to block bug 565552.

The point of this bug is that, before bug 776708, you could find the next/previous match by pressing Alt+N and Alt+P respectively from the findbar. You can't do that now. This regression is still valid, and its resolution should not be influenced by what should (not) be shown in the tooltips. Setting fields back.
Blocks: 776708
Severity: trivial → normal
Keywords: regression
Summary: Previous and Next keyboard shortcuts in the Find bar are missing the shortcuts tooltips → Firefox 25 broke Previous and Next keyboard shortcuts in the Find bar
Version: Trunk → 25 Branch
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.