932682 - [bluedroid] Support Pair/Unpair, Bond state changed callback

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Enable pin code/secure simple pairing, and BondChangedState callback

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 932682 - [bluedroid] Support Pair/Unpair, Bond state changed callback

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 826638 [details] [diff] [review]
Bug 932682 - [bluedroid] Support Pair/Unpair, Bond state changed callback

Review of attachment 826638 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Shawn, please see my comments below.

::: dom/bluetooth/BluetoothServiceBluedroid.cpp
@@ +877,5 @@
> +
> +  int ret = sBtInterface->remove_bond(&remoteAddress);
> +  if (ret != BT_STATUS_SUCCESS) {
> +    ReplyStatusError(aRunnable, ret,
> +                     NS_LITERAL_STRING("RemoveDevice"));

Need to return NS_OK here. Please refer to function CreatePairedDeviceInternal().

@@ +908,5 @@
> +  if (ret != BT_STATUS_SUCCESS) {
> +    ReplyStatusError(aRunnable, ret,
> +                     NS_LITERAL_STRING("SetPinCode"));
> +
> +    return false;

For consistency with other similar functions, 'true' should be returned in this case.

@@ +940,5 @@
> +  StringToBdAddressType(aDeviceAddress, &remoteAddress);
> +
> +  int ret = sBtInterface->ssp_reply(&remoteAddress,
> +      (bt_ssp_variant_t)0,
> +      aConfirm, 0);

nit: weird indentation.

@@ +944,5 @@
> +      aConfirm, 0);
> +  if (ret != BT_STATUS_SUCCESS) {
> +    ReplyStatusError(aRunnable, ret,
> +                     NS_LITERAL_STRING("SetPairingConfirmation"));
> +    return false;

For consistency with other similar functions, 'true' should be returned in this case.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 932682 - [bluedroid] Support Pair/Unpair, Bond state changed callbackBug932682.patch

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Patch revised.

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 932682 - [bluedroid] Support Pair/Unpair, Bond state changed callback

Comment 6

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 827334 [details] [diff] [review]
Bug 932682 - [bluedroid] Support Pair/Unpair, Bond state changed callback

Review of attachment 827334 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!

Comment 7

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fd2e2d6edbd4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd2e2d6edbd4