932750 - Add helper methods to GaiaData to get and set Gecko prefs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Bob Silverberg [:bsilverberg]]

These methods should be added to [1]. At this point I'm not sure if set will work, and we only need get for now, but it's worth investigating and trying to get set working now as well.

Sample code for getting a Gecko pref is:

self.marionette.execute_script("SpecialPowers.getBoolPref('privacy.donottrackheader.value');", special_powers=True)

Sample for setting a Gecko pref can be seen at [2].

I suggest adding a method for each get and set, and those methods would have to accept both the pref and the datatype, so that the correct JS statement can be crafted.

[1] https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L133
[2] http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#l434

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13644

Pointer to Github pull-request

Comment 2

[Bob Silverberg [:bsilverberg]]

This should be cherry-picked into v1.2 after it is merged into master.

Comment 3

[Bob Silverberg [:bsilverberg]]

Thanks for the reviews, folks (but you all forgot to r- the PR). I have updated the PR so please re-review.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Bob Silverberg [:bsilverberg] from comment #3)
> Thanks for the reviews, folks (but you all forgot to r- the PR). I have
> updated the PR so please re-review.

I reviewed, but I wasn't asked for one, so I didn't r- ;)

Comment 5

[Bob Silverberg [:bsilverberg]]

(In reply to Dave Hunt (:davehunt) from comment #4)
> (In reply to Bob Silverberg [:bsilverberg] from comment #3)
> > Thanks for the reviews, folks (but you all forgot to r- the PR). I have
> > updated the PR so please re-review.
> 
> I reviewed, but I wasn't asked for one, so I didn't r- ;)

Hey, a review is a review, isn't it? ;)

Comment 6

[Bob Silverberg [:bsilverberg]]

Comment on attachment 831252 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13644

I have made another update to the PR, which includes squashing the commits.

Comment 7

[[:AndreiH]]

Comment on attachment 831252 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13644

This LGTM, triggered another build on Travis and looks good

Comment 8

[Zac C (:zac)]

Comment on attachment 831252 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13644

r+

Comment 9

[Zac C (:zac)]

Merged for master:
https://github.com/mozilla-b2g/gaia/commit/42de07a7855bac4ad4de6602896fb7ada906723f

Comment 10

[[:AndreiH]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13834

Pointer to Github pull-request

Comment 11

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8334490 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13834

Comments in the PR.

Comment 12

[[:AndreiH]]

Comment on attachment 8334490 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13834

Updated the pull for v1.2

Comment 13

[Bob Silverberg [:bsilverberg]]

Landed in v1.2 https://github.com/mozilla-b2g/gaia/commit/2d8331f137aaa659b7f8520dd293ae6cea2a0f25