932768 - Remove vestigial decompiler hacks from BytecodeEmitter

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andy Wingo [:wingo]]

After bug 932180, SRC_CATCH annotations are no longer used.

Comment 1

[Andy Wingo [:wingo]]

Attachment: Remove vestigial decompiler hacks from BytecodeEmitter

Comment 2

[Nicholas Nethercote [inactive]]

Man, all this time has passed and we're still finding decompiler turds hidden under the furniture.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 824632 [details] [diff] [review]
Remove vestigial decompiler hacks from BytecodeEmitter

Review of attachment 824632 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/BytecodeEmitter.cpp
@@ +4687,5 @@
>  #endif
>          if (op == JSOP_POP && !EmitTree(cx, bce, pn3))
>              return false;
>  
> +        /* Always emit the POP or NOP, to help IonBuilder. */

Kill the comma while you're here.

Comment 4

[Andy Wingo [:wingo]]

Attachment: Remove vestigial decompiler hacks from BytecodeEmitter

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6b742a22142

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e6b742a22142