Remove vestigial decompiler hacks from BytecodeEmitter

RESOLVED FIXED in mozilla28

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wingo, Assigned: wingo)

Tracking

unspecified
mozilla28
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
After bug 932180, SRC_CATCH annotations are no longer used.
(Assignee)

Comment 1

5 years ago
Created attachment 824632 [details] [diff] [review]
Remove vestigial decompiler hacks from BytecodeEmitter
(Assignee)

Updated

5 years ago
Assignee: nobody → wingo
(Assignee)

Updated

5 years ago
Depends on: 932312
(Assignee)

Updated

5 years ago
Attachment #824632 - Flags: review?(jwalden+bmo)
(Assignee)

Updated

5 years ago
Summary: Remove SRC_CATCH, unused after decompiler rewrite → Remove vestigial decompiler hacks from BytecodeEmitter
Man, all this time has passed and we're still finding decompiler turds hidden under the furniture.
Comment on attachment 824632 [details] [diff] [review]
Remove vestigial decompiler hacks from BytecodeEmitter

Review of attachment 824632 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/BytecodeEmitter.cpp
@@ +4687,5 @@
>  #endif
>          if (op == JSOP_POP && !EmitTree(cx, bce, pn3))
>              return false;
>  
> +        /* Always emit the POP or NOP, to help IonBuilder. */

Kill the comma while you're here.
Attachment #824632 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 8333874 [details] [diff] [review]
Remove vestigial decompiler hacks from BytecodeEmitter
(Assignee)

Updated

5 years ago
Attachment #824632 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #8333874 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e6b742a22142
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.