Closed Bug 932768 Opened 6 years ago Closed 6 years ago

Remove vestigial decompiler hacks from BytecodeEmitter

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: wingo, Assigned: wingo)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

After bug 932180, SRC_CATCH annotations are no longer used.
Assignee: nobody → wingo
Depends on: 932312
Attachment #824632 - Flags: review?(jwalden+bmo)
Summary: Remove SRC_CATCH, unused after decompiler rewrite → Remove vestigial decompiler hacks from BytecodeEmitter
Man, all this time has passed and we're still finding decompiler turds hidden under the furniture.
Comment on attachment 824632 [details] [diff] [review]
Remove vestigial decompiler hacks from BytecodeEmitter

Review of attachment 824632 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/BytecodeEmitter.cpp
@@ +4687,5 @@
>  #endif
>          if (op == JSOP_POP && !EmitTree(cx, bce, pn3))
>              return false;
>  
> +        /* Always emit the POP or NOP, to help IonBuilder. */

Kill the comma while you're here.
Attachment #824632 - Flags: review?(jwalden+bmo) → review+
Attachment #824632 - Attachment is obsolete: true
Attachment #8333874 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e6b742a22142
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.