Closed Bug 932793 Opened 6 years ago Closed 6 years ago

Intermittent test "thread_ui.js > scrolling scroll 100px, should be detected as a manual scroll"

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

defect
Not set

Tracking

(b2g-v1.3 fixed)

RESOLVED FIXED
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: rik, Assigned: julienw)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
steveck
: review+
Details | Review
"Error: timeout of 2000ms exceeded"

Tests failing intermittently make me really sad. CAN I HAZ fix? https://www.milemoa.com/bbs/files/attach/images/53/681/018/001/bc0e654d694175c7219028deddb28de7.jpg
The issue here is that we set scrollTop, and waiting for a "scroll" event to do something.

The workaround to get a synchronous test is sending the scroll event ourselves.
Assignee: nobody → felash
Attached file Github pull request
Bug 932793 - Intermittent test "thread_ui.js > scrolling scroll 100px, should be detected as a manual scroll" r=schung
    
    * Fix intermittent scripts by sending the scroll event in the test
    * Fix bad tests that were revealed in the process: `done` callback set on the
      suite function instead of the test function, wrong SMS messages.

 apps/sms/test/unit/thread_ui_test.js |   46 ++++++++++++++++++++++++++--------------------
Attachment #8344196 - Flags: review?(schung)
Comment on attachment 8344196 [details] [review]
Github pull request

Only one small question in https://github.com/julienw/gaia/commit/eba6cab7c26ee7193784a51d64715d951f695560#commitcomment-4816570 and I'm ok with patch. Thanks for the integration test fixing.
Attachment #8344196 - Flags: review?(schung) → review+
master: 529c6fb38e1c5fca324bb1dd96d73d375ce1b5c9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
a=tests since it was making v1.3 red
v1.3: cb6ee04e4f784d3dc2fb2cbabba64932236427ae
See Also: → 1222344
You need to log in before you can comment on or make changes to this bug.