932822 - L10N string "eventNodes" needs pluralization

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Pavel Cvrcek [:JasnaPaka]]

In the file debugger.properties there is:

# LOCALIZATION NOTE (eventNodes): The text to display in the events tab when
# an event is listened on more than one target node.
eventNodes=%S nodes

I think we needs pluralization here.

Comment 1

[Victor Porof [:vporof][:vp]]

(In reply to Pavel Cvrcek (Mozilla.cz) [:JasnaPaka] from comment #0)
> 
> I think we needs pluralization here.

Good catch, but "nodes" will always be >= 2.

Comment 2

[Pavel Cvrcek [:JasnaPaka]]

(In reply to Victor Porof [:vp] from comment #1)
> Good catch, but "nodes" will always be >= 2.

There are many plural forms around the world. See:
https://developer.mozilla.org/en/docs/Localization_and_Plurals

In this example we have "%S nodes" and for Czech translation it means:

2 - 4: %s uzly
5>=:   %s uzlů

Comment 3

[Francesco Lodolo [:flod]]

Argh, I missed this one. String was introduced in bug 800857.

Victor: Pavel is right, we need a proper plural form in this case.

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Pavel Cvrcek (Mozilla.cz) [:JasnaPaka] from comment #2)
> (In reply to Victor Porof [:vp] from comment #1)
> > Good catch, but "nodes" will always be >= 2.
> 
> There are many plural forms around the world. See:
> https://developer.mozilla.org/en/docs/Localization_and_Plurals

Oooh! Today I learned :) Sorry for closing as invalid.

Comment 5

[Eddy Bruel [:ejpbruel]]

(In reply to Pavel Cvrcek (Mozilla.cz) [:JasnaPaka] from comment #0)
> In the file debugger.properties there is:
> 
> # LOCALIZATION NOTE (eventNodes): The text to display in the events tab when
> # an event is listened on more than one target node.
> eventNodes=%S nodes
> 
> I think we needs pluralization here.

Pavel, would you be willing to fix this?

Comment 6

[David Walsh :davidwalsh]

This string is no longer used but, as we'll be implementing event breakpoints in the debugger very soon, I'll leave and see if it still applies. Will evaluate after when the event listener feature is complete.

Comment 7

[David Walsh :davidwalsh]

This string was removed so I'm closing this.