Closed
Bug 932833
Opened 11 years ago
Closed 11 years ago
[Settings] 1.3 Visual Refresh of Settings icons
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: amylee, Assigned: pivanov)
References
Details
(Whiteboard: visual design, visual-tracking, jian)
Attachments
(5 files, 4 obsolete files)
A refresh of some of the settings icons for 1.3.
Reporter | ||
Updated•11 years ago
|
Blocks: 1.3-visual-refresh
Reporter | ||
Updated•11 years ago
|
Assignee: amylee.design → pivanov
Reporter | ||
Comment 1•11 years ago
|
||
Hi Pavel, Attached are the updated settings sprites. Please note that a new icon has been added to the sprite (chat bubble - messages). Let me know if you have any questions Thanks
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8333766 -
Flags: feedback?(epang)
Comment 3•11 years ago
|
||
Comment on attachment 8333766 [details] [review] patch for Gaia/master Redirecting feedback from Amy for this bug since she made the changes to the settings icons. Amy I'll attached screen caps of the updated icons since I know you won't be able to flash Pavel's patch. If all good please give the patch Feedback+ so Pavel can ask for review. Thanks!
Attachment #8333766 -
Flags: feedback?(epang) → feedback?(amylee.design)
Comment 4•11 years ago
|
||
Flags: needinfo?(amylee.design)
Reporter | ||
Comment 5•11 years ago
|
||
Hey Pavel, I noticed that some of the icons aren't centered. I've adjusted the sprite so the icons are sitting centered to bounding boxes of 30x30px and 45x45px. Hopefully this fixes the alignment issue. Can you please replace the sprites with the ones I've attached? Also, the sprite background colour set is to #F4F4F4. This is the background colour for v1.3 build. It's slightly lighter than the old build so I assume that the background colour of settings will be changed to this for the 1.3 visual refresh?
Flags: needinfo?(amylee.design)
Reporter | ||
Comment 6•11 years ago
|
||
Hi Pavel, Here are the rest of the icons for settings that need to be replaced. Let me know if you have any questions. Thanks!
Assignee | ||
Comment 7•11 years ago
|
||
Hey Eric can you help with the latest icons, as we talk?
Comment 8•11 years ago
|
||
Hi Pavel, I've organized the setting icons into the gaia structure. Thanks!
Attachment #8333514 -
Attachment is obsolete: true
Attachment #8333902 -
Attachment is obsolete: true
Attachment #8333929 -
Attachment is obsolete: true
Flags: needinfo?(pivanov)
Updated•11 years ago
|
Attachment #8333766 -
Flags: feedback?(amylee.design)
Comment 9•11 years ago
|
||
flag me for feedback when ready :) thanks!
Assignee | ||
Updated•11 years ago
|
Attachment #8333766 -
Flags: feedback?(epang)
Comment 10•11 years ago
|
||
Hi Pavel, I just tested the patch. A few of the images need to be replaced. Can you use the images attached to replace the ones currently in the patch? Thanks!
Assignee | ||
Comment 11•11 years ago
|
||
Hey Eric, Sure, can you check the PR again?
Flags: needinfo?(pivanov)
Comment 12•11 years ago
|
||
Comment on attachment 8333766 [details] [review] patch for Gaia/master everything looks good now, thanks Pavel!
Attachment #8333766 -
Flags: feedback?(epang) → feedback+
Assignee | ||
Updated•11 years ago
|
Attachment #8333766 -
Flags: review?(ehung)
Comment 13•11 years ago
|
||
Comment on attachment 8333766 [details] [review] patch for Gaia/master looks good to me, thank you. :)
Attachment #8333766 -
Flags: review?(ehung) → review+
Comment 14•11 years ago
|
||
merged into gaia master: https://github.com/mozilla-b2g/gaia/commit/568cf51284a14e4e855d01a43b355925b09a8e04
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 15•11 years ago
|
||
Hi Pavel, I'm still noticing that there is a slight difference in colour between the sprite background and the settings background (you can see faint box outline around each icon). The background colour should be #f4f4f4 Thanks
Flags: needinfo?(pivanov)
Reporter | ||
Comment 16•11 years ago
|
||
Hey Pavel, I just found the bug for changing the settings background. So please disregard my last message. Thanks! (In reply to Amy from comment #15) > Hi Pavel, > > I'm still noticing that there is a slight difference in colour between the > sprite background and the settings background (you can see faint box outline > around each icon). The background colour should be #f4f4f4 > > Thanks
Assignee | ||
Comment 17•11 years ago
|
||
Yeah :) no problem ... I made the patch for the Bug 941628 :)
Flags: needinfo?(pivanov)
Reporter | ||
Comment 18•11 years ago
|
||
Hey Pavel, There's been a request to adjust the size and weight of two of the icons (Device Info and Help). Can you please replace the sprites? Thanks
Reporter | ||
Comment 19•11 years ago
|
||
Here are the static and active states of the sprites
Attachment #8340105 -
Attachment is obsolete: true
Comment 20•11 years ago
|
||
(In reply to Amy from comment #19) > Created attachment 8340108 [details] > Settings_Sprite_v2.zip > > Here are the static and active states of the sprites Hey Amy, Since this bug is already marked resolved fixed can you open a new followup bug and add it to the google doc? Make sure to attach the assets for Pavel as to the other bug. Thanks!
Flags: needinfo?(amylee.design)
Reporter | ||
Comment 21•11 years ago
|
||
(In reply to Eric Pang [:epang] from comment #20) > (In reply to Amy from comment #19) > > Created attachment 8340108 [details] > > Settings_Sprite_v2.zip > > > > Here are the static and active states of the sprites > > Hey Amy, > Since this bug is already marked resolved fixed can you open a new followup > bug and add it to the google doc? Make sure to attach the assets for Pavel > as to the other bug. Thanks! Hi Eric, I've created a follow-up bug 944536.
Flags: needinfo?(amylee.design)
You need to log in
before you can comment on or make changes to this bug.
Description
•