Display continuous reports in reps dashboard

VERIFIED FIXED

Status

Mozilla Reps
reps.mozilla.org
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: hoosteeno, Assigned: agibson)

Tracking

Details

(Whiteboard: [kb=1178456] )

Attachments

(2 attachments)

Once we have some continuous reports, we'll want to show them in the dashboard. 

A mockup is here: http://cl.ly/image/1r3X2N3r121U

Show a custom reports table for each audience: Mine, Mentees, and All. The Mentees view is only visible to those in the Mentors and Council groups.

If there are more than 5 reports of any type, show a link to "More". The More link will point to URLs like the examples below:

Mine example: https://reps.mozilla.org/reports/rep/sawrubh/
Mentees example: https://reps.mozilla.org/reports/mentor/debloper/
All example: https://reps.mozilla.org/reports/
(In reply to Justin Crawford [:hoosteeno] from comment #0) 
> If there are more than 5 reports of any type, show a link to "More". The
> More link will point to URLs like the examples below:
> 
> Mine example: https://reps.mozilla.org/reports/rep/sawrubh/
> Mentees example: https://reps.mozilla.org/reports/mentor/debloper/
> All example: https://reps.mozilla.org/reports/

Can you clarify what triggers the "More" link on the mockup? My understanding is the dashboard would only show the number of reports over certain time periods, not report types.
Flags: needinfo?(hoosteeno)
It's unlikely when someone chooses the "All" filter in the dashboard that we will want to show the names of all people who have reported anything ever. We will probably wish to limit that list to a reasonable number, something that doesn't push the bottom of the page down into the molten center of the earth. :) Even 10 names may be too long, but let's assume 10 for now.

When there are more than 10 names in either of the list types (mentees, all), I suggest we create a "More" link that links to a link similar to those in comment 0.
Flags: needinfo?(hoosteeno)
Comment 2 raises some questions. Williamr, can you specify these?

* How should the list be sorted such that the first 10 results in the list views make sense? Alphabetical? By whoever has reported most recently? By whoever has the most reports?
* Where should the More link be? Can you add it to the mockup?
* Is 10 the right number?
Flags: needinfo?(williamr)
Whiteboard: [kb=1178456]
Good questions - some suggestions below.

(In reply to Justin Crawford [:hoosteeno] from comment #3)
> Comment 2 raises some questions. Williamr, can you specify these?
> 
> * How should the list be sorted such that the first 10 results in the list
> views make sense? Alphabetical? By whoever has reported most recently? By
> whoever has the most reports?

Sort by who has reported most recently (most recent at the top). This way you can tell at a glance who has reported recently by looking at the top of the list. A mentor can easily see that the people at the bottom of his mentees list have not reported in a while.

We could allow all six columns to be sorted, similar to how the dashboard tables with bug information has header columns that can be clicked to sort the table.

> * Where should the More link be? Can you add it to the mockup?
I suggest placing the link below the table, and I'll add this to the mockup.

> * Is 10 the right number?
Let's try 10 and see how that feels.
Flags: needinfo?(williamr)
Created attachment 831299 [details]
mockup

> * Where should the More link be? Can you add it to the mockup?
Attaching an updated mockup showing 10 entries in the tables and the More link below the tables.
(In reply to William Reynolds [:williamr] from comment #4)
> Good questions - some suggestions below.
> 
> (In reply to Justin Crawford [:hoosteeno] from comment #3)
> > Comment 2 raises some questions. Williamr, can you specify these?
> > 
> > * How should the list be sorted such that the first 10 results in the list
> > views make sense? Alphabetical? By whoever has reported most recently? By
> > whoever has the most reports?
> 
> Sort by who has reported most recently (most recent at the top). 

This works.

> This way
> you can tell at a glance who has reported recently by looking at the top of
> the list. A mentor can easily see that the people at the bottom of his
> mentees list have not reported in a while.

I think this doesn't work -- not on the dashboard, not as currently conceived. Because the bottom of the list will never show up on the dashboard. You'll have to click "more" to see the entire list.

> We could allow all six columns to be sorted, similar to how the dashboard
> tables with bug information has header columns that can be clicked to sort
> the table.

I think for a 10-item list of the most recently filed reports, this is overkill. It might make sense in the context of the full list of reports, though.
Assignee: nobody → agibson
Status: NEW → ASSIGNED
(Assignee)

Comment 7

5 years ago
Created attachment 8342993 [details]
dashboard-reporting.jpg

Attached a screenshot of proposed static UI, please let me know any feedback :)

Thanks
Attachment #8342993 - Flags: feedback?(williamr)
I think the static mockup looks fantastic! Nice work.

:williamr, I'm wondering if we need a link from "mine" to my actual reports? On all the other views the names of the rep is a link to the rep's reports, but right now I don't see a direct way to get to my own reports. Am I missing it?
(Assignee)

Comment 9

5 years ago
(In reply to Justin Crawford [:hoosteeno] from comment #8) 
> :williamr, I'm wondering if we need a link from "mine" to my actual reports?

Good suggestion, I've added a link to 'view my reports' bottom left underneath the "mine" table display.

I've published a branch here containing the static UI here so this is ready to pick up:

https://github.com/alexgibson/remo/tree/display-continuous-reports-in-dashboard
Comment on attachment 8342993 [details]
dashboard-reporting.jpg

(In reply to Alex Gibson [:agibson] from comment #9)
> (In reply to Justin Crawford [:hoosteeno] from comment #8) 
> > :williamr, I'm wondering if we need a link from "mine" to my actual reports?
> 
> Good suggestion, I've added a link to 'view my reports' bottom left
> underneath the "mine" table display.

r+. This mockup looks wonderful, and I like the suggestion for adding a 'view my reports' link. Thanks Alex and Justin!
Attachment #8342993 - Flags: feedback?(williamr) → feedback+
Summary: Display continuous reports in dashboard → Display continuous reports in reps dashboard

Updated

5 years ago
Version: unspecified → next

Comment 11

5 years ago
Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/48e934a7ff6fab66214c93acff5993a42dfd3977
[bug 932853] Display continuous reports in dashboard

https://github.com/mozilla/remo/commit/8bf68cb3b701866e2ca903cdb029907d48d0cb1e
Merge pull request #604 from akatsoulas/948361

[fix bug 932853] [fix bug 948361] Display continuous reports on dashboard.

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Verified on stage after the following checks:

* New reports activity dashboard is displayed for: my reports, my mentees reports, all reports
* Links for the above categories redirects user to the matching reports list
Status: RESOLVED → VERIFIED

Comment 13

5 years ago
Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/3f20dc3a543977bedaf97018f534e97437f2c34f
[bug 932853] Do not display 'new report' button if flag not active.

https://github.com/mozilla/remo/commit/91f5872634ef9d9bdf93a9d476bfd9a889356bbc
Merge pull request #621 from glogiotatidis/hidebutton

[bug 932853] Do not display 'new report' button if flag not active.
Version: next → 423
Will the Empty and Overdue columns be going away on the dashboard? Will these be redundant concepts in the new system?
(In reply to Brian King [:kinger] from comment #14)
> Will the Empty and Overdue columns be going away on the dashboard? Will
> these be redundant concepts in the new system?

Yes, those columns will go away in the new reporting system.

Mentors will see reporting metrics for their mentees. This includes the recent streak, longest streak, reports in the last 2 weeks, reports in the last 10 weeks, and total reports filed. See Attachment #8342993 [details].
You need to log in before you can comment on or make changes to this bug.