932870 - Used the parsed-selector cache even for invalid selectors

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We want this because jQuery commonly passes those in (when consumers are using its selector extensions), and we'd like to avoid reparsing them.  What we can do is just cache a null selector and use null to indicate "invalid, throw".

On the testcase in bug 922048 this drops my times from about 1850ms to about 1650ms.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Cache the "invalid selector" state in our parsed-selector cache as well when doing querySelector(All).

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 824732 [details] [diff] [review]
Cache the "invalid selector" state in our parsed-selector cache as well when doing querySelector(All).


>+    } else if (!selectorList) {
>+      // This is the "only pseudo-element selectors" case, which is
>+      // not common, so just don't worry about caching it.  That way a
>+      // null cached value can always indicate an invalid selector.
>+      // Also don't try to do any matching, of course.
>+      return NS_OK;
Odd, but apparently http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsINode.cpp#2311 does that.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90ca96b3e198

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/90ca96b3e198