932928 - [Australis] Show something when "More Tools" section is empty in customization mode

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Zhenshuo Fang (:fang) - Firefox UX Team]

In customization mode, we should show something when user moved all the tools and the "more tools" section is empty. The message could be something like "Want more tools? Go and install more Add-ons"

Comment 1

[Mike de Boer [:mikedeboer]]

Zhenshuo, can you tell us what we should implement here? Preferably the link text (could be the same as you mentioned in comment 0 earlier) and the action of what happens when you click it.

Thanks!

Comment 2

[Zhenshuo Fang (:fang) - Firefox UX Team]

Attachment: MoreTools.jpg

OK, here's what I have:
"Want more tools? Choose from thousands of add-ons"
The link opens about:addons in a new tab.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Specifically, open the Disco pane in about:addons:
  BrowserOpenAddonsMgr("addons://discovery/");

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 5

[:Gijs (he/him)]

Comment on attachment 8363059 [details] [diff] [review]
Patch

Review of attachment 8363059 [details] [diff] [review]:
-----------------------------------------------------------------

f+ but I'm concerned about being able to move items back to the palette if it's empty.

::: browser/components/customizableui/content/customizeMode.inc.xul
@@ +9,5 @@
>      </label>
>      <vbox id="customization-palette" flex="1"/>
> +    <hbox id="customization-empty" hidden="true">
> +      <label>
> +        &customizeMode.menuAndToolbars.empty;

Nit: does this need to have whitespace on either side? I suspect not, but just checking.

::: browser/components/customizableui/src/CustomizeMode.jsm
@@ +273,5 @@
>      let document = this.document;
>      let documentElement = document.documentElement;
>  
>      // Hide the palette before starting the transition for increased perf.
>      this.visiblePalette.hidden = true;

If this is hidden first, won't that destroy the binding on the nodes inside it? I am so paranoid about these XBL bindings these days...

@@ +920,5 @@
>    },
>  
> +  _updateEmptyPaletteNotice: function() {
> +    let paletteEmpty = !this.visiblePalette.childElementCount;
> +    this.visiblePalette.hidden = paletteEmpty;

Why do we need to hide the palette if it's empty? Does it have a minimum size or something? Separately, I'm pretty sure our drag handlers are on that thing, so how can people move items back if the palette's hidden?

Comment 6

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #5)
> ::: browser/components/customizableui/src/CustomizeMode.jsm
> @@ +273,5 @@
> >      let document = this.document;
> >      let documentElement = document.documentElement;
> >  
> >      // Hide the palette before starting the transition for increased perf.
> >      this.visiblePalette.hidden = true;
> 
> If this is hidden first, won't that destroy the binding on the nodes inside
> it? I am so paranoid about these XBL bindings these days...

Eh, disregard this comment.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2

Comment 8

[:Gijs (he/him)]

Comment on attachment 8363097 [details] [diff] [review]
Patch v2

Review of attachment 8363097 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/be932ecd964e

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/be932ecd964e