Closed Bug 932946 Opened 11 years ago Closed 10 years ago

Enable npm caching when travis offers it to us

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jlal, Assigned: julienw)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Details | Review
Travis will cache node_modules which should shave some initial startup time
Attached file github PR
This change makes us use Travis' npm caching capabilities, which should give us more reliability and speed.
Assignee: nobody → felash
Attachment #8376966 - Flags: review?(yurenju.mozilla)
And thanks Thomas, without your comment, I wouldn't have looked at it :)
I think this feature is only available for private repository?
Flags: needinfo?(felash)
Comment on attachment 8376966 [details] [review]
github PR

will add more directories
Attachment #8376966 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(felash)
Comment on attachment 8376966 [details] [review]
github PR

I added the test-agent's node_modules directory as well.

I checked the explanations from Travis [1] and I think it makes no sense to add the directories for XULrunner (as we would still download it) or b2g (as we need new versions when they're here and mozilla-download is not smart enough yet to figure this out).

It might make sense to add Python directories for Gaia UI Tests but I'm not sure how to do it because I don't know where they're downloaded. We can add them later if we find this works as expected.

Also, it's said this works only with "private repositories". Not sure whether we have one.

[1] http://docs.travis-ci.com/user/caching/
Attachment #8376966 - Flags: review?(yurenju.mozilla)
(In reply to Yuren [:yurenju][:小朱] from comment #4)
> I think this feature is only available for private repository?

Yeah, I don't know. Anyway, it's gives no harm to enable it, and then contact them to see whether we can enable it for us? Since we pay and have more jobs, maybe we're in the same configuration?
(In reply to Julien Wajsberg [:julienw] from comment #6)
> 
> I think it makes no sense to
> add the directories for XULrunner (as we would still download it)

Actually, it could make sense to add the directory for XULrunner, as we would actually not download it. But it's quite big and Travis says that big directories are probably not worth it.

I'd say we could try it later if the basic things already work, but if you think it's worth it, I could add it now.
https://twitter.com/travisci/status/435339317146578944
ok, it's not available to us :(
Attachment #8376966 - Flags: review?(yurenju.mozilla)
We don't use Travis anymore.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: