Enable npm caching when travis offers it to us

RESOLVED WONTFIX

Status

Firefox OS
Gaia
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: lightsofapollo, Assigned: julienw)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Travis will cache node_modules which should shave some initial startup time

Comment 1

4 years ago
This is now feasible :-) http://about.travis-ci.org/blog/2013-12-05-speed-up-your-builds-cache-your-dependencies/
(Assignee)

Comment 2

4 years ago
Created attachment 8376966 [details] [review]
github PR

This change makes us use Travis' npm caching capabilities, which should give us more reliability and speed.
Assignee: nobody → felash
Attachment #8376966 - Flags: review?(yurenju.mozilla)
(Assignee)

Comment 3

4 years ago
And thanks Thomas, without your comment, I wouldn't have looked at it :)
I think this feature is only available for private repository?
Flags: needinfo?(felash)
(Assignee)

Comment 5

4 years ago
Comment on attachment 8376966 [details] [review]
github PR

will add more directories
Attachment #8376966 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(felash)
(Assignee)

Comment 6

4 years ago
Comment on attachment 8376966 [details] [review]
github PR

I added the test-agent's node_modules directory as well.

I checked the explanations from Travis [1] and I think it makes no sense to add the directories for XULrunner (as we would still download it) or b2g (as we need new versions when they're here and mozilla-download is not smart enough yet to figure this out).

It might make sense to add Python directories for Gaia UI Tests but I'm not sure how to do it because I don't know where they're downloaded. We can add them later if we find this works as expected.

Also, it's said this works only with "private repositories". Not sure whether we have one.

[1] http://docs.travis-ci.com/user/caching/
Attachment #8376966 - Flags: review?(yurenju.mozilla)
(Assignee)

Comment 7

4 years ago
(In reply to Yuren [:yurenju][:小朱] from comment #4)
> I think this feature is only available for private repository?

Yeah, I don't know. Anyway, it's gives no harm to enable it, and then contact them to see whether we can enable it for us? Since we pay and have more jobs, maybe we're in the same configuration?
(Assignee)

Comment 8

4 years ago
(In reply to Julien Wajsberg [:julienw] from comment #6)
> 
> I think it makes no sense to
> add the directories for XULrunner (as we would still download it)

Actually, it could make sense to add the directory for XULrunner, as we would actually not download it. But it's quite big and Travis says that big directories are probably not worth it.

I'd say we could try it later if the basic things already work, but if you think it's worth it, I could add it now.
(Assignee)

Comment 9

4 years ago
https://twitter.com/travisci/status/435339317146578944
ok, it's not available to us :(
(Assignee)

Updated

4 years ago
Attachment #8376966 - Flags: review?(yurenju.mozilla)
(Assignee)

Comment 10

3 years ago
We don't use Travis anymore.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.