932957 - Missing username from app review listing

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: reviewer name missing.png

steps to reproduce:
1. Load https://marketplace.firefox.com/app/counters/ratings
2. Notice that one of the reviews is missing the name of the reviewer

See screenshot.

Comment 1

[Matt Basta [:basta]]

The API is indeed reporting that the user has no display name:

http://cl.ly/image/160b3w1i271e

Comment 2

[Christopher Van Wiemeersch [:cvan]]

SELECT users.id, users.display_name FROM reviews INNER JOIN addons ON (reviews.addon_id = addons.id) INNER JOIN users ON (reviews.user_id = users.id) WHERE ("en-us"="en-us" AND addons.app_slug = 'counters' ) ORDER BY reviews.created DESC LIMIT 21;
+---------+--------------------+
| id      | display_name       |
+---------+--------------------+
| 6133935 |                    | 
| 6254801 | andre alves garzia | 
+---------+--------------------+
2 rows in set (0.02 sec)

Likely related to bug 869656. I don't think we have validation in the API here.

Comment 3

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/fcca2025059c433840efb751a747ef81ff5a8a1d

STR:
- Log in in consumer pages on -dev
- Go to settings
- Empty the field with your display name
- Right click and choose Inspect Element on that field
- Remove the "pattern" attribute on that field, close the inspector
- Submit the form
- You should see an error and the changes should not have been saved

Comment 4

[krupa raj[:krupa]]

verified fixed @ https://www.dropbox.com/s/swenhhm74wdhhtf/Screenshot%202014-02-19%2016.58.32.png