Closed Bug 932999 Opened 10 years ago Closed 9 years ago

Defect - Download button has white arrow on light background

Categories

(Firefox for Metro Graveyard :: Theme, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
Theme
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: icon, polish, uiwanted, Whiteboard: [block28] feature=defect c=tbd u=tbd p=1)

Attachments

(2 files, 3 obsolete files)

patch
14.07 KB, patch
rsilveira
: review+
Details | Diff | Splinter Review
icon-navBar-download.zip
8.88 KB, application/zip
Details 
The mockup in bug 831942 shows two states for the download button: light icon on dark background when a notification is visible, or dark icon on light background otherwise.

Currently it always has a light icon on a light background.
Blocks: metrov1backlog
Whiteboard: [triage] → [triage] feature=defect c=tbd u=tbd p=0
Whiteboard: [triage] feature=defect c=tbd u=tbd p=0 → [release28] feature=defect c=tbd u=tbd p=0
Michael, we'll need a new version of this icon.  We are currently using the one from attachment 726702 [details] which was designed for a dark background.  We'll need to replace this with one for a light background, similar to this:

http://mxr.mozilla.org/mozilla-central/source/browser/metro/theme/images/navbar-menu.png

As with all our icons, we will also need 140% and 180% scaled versions for high-dpi screens.

Thanks!
Assignee: nobody → mmaslaney
Keywords: icon, uiwanted
Attached file icon-navBar-download.zip (obsolete) — 
Let me know if there are additional assets needed.
Assignee: mmaslaney → mbrubeck
Hey Matt, will you be taking this Defect during IT#20?  If so, can you provide a point value.  Thanks.
Flags: needinfo?(mbrubeck)
Attached patch patch — — Splinter Review 
Use the new images from attachment 8336287 [details].

(In reply to Marco Mucci [:MarcoM] from comment #3)
> Hey Matt, will you be taking this Defect during IT#20?  If so, can you
> provide a point value.  Thanks.

Michael did the real work; I'm just checking it in.  I'm not sure how we want to track UX work like this...
Attachment #8338043 - Flags: review?(rsilveira)
Flags: needinfo?(mbrubeck)
Comment on attachment 8338043 [details] [diff] [review]
patch

Review of attachment 8338043 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8338043 - Flags: review?(rsilveira) → review+
Thanks Matt.  If it is just a check-in I'll leave it at 0 points but I'll still add it to the iteration.  That way we can put it through the QA cycle at the end.
Blocks: metrov1it20
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [release28] feature=defect c=tbd u=tbd p=0 → [block28] feature=defect c=tbd u=tbd p=0
https://hg.mozilla.org/integration/fx-team/rev/dbca16978da7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attached image icon-navBar-download.png (obsolete) — 
Color corrected.
Attachment #8336287 - Attachment is obsolete: true
Attached file icon-navBar-download.zip (obsolete) — 
Sorry, full set of color corrected.
Attachment #8338190 - Attachment is obsolete: true
Flags: needinfo?(mbrubeck)
Minor tweak.
Attachment #8338192 - Attachment is obsolete: true
Target Milestone: --- → Firefox 28
Comment on attachment 8338263 [details]
icon-navBar-download.zip

Replaced the icons with the color-corrected versions:
https://hg.mozilla.org/integration/fx-team/rev/07777e5326bf
Flags: needinfo?(mbrubeck)
Depends on: 945539
Whiteboard: [block28] feature=defect c=tbd u=tbd p=0 → [block28] feature=defect c=tbd u=tbd p=1
You need to log in before you can comment on or make changes to this bug.