Closed
Bug 933050
Opened 11 years ago
Closed 11 years ago
DataStore.add should receive an optional key value.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file)
21.69 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This will make .add() similar to what IDB ObjectStore does. In the same bug we should rename .update() to .put().
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
Here the strings are still numbers.
Attachment #826009 -
Flags: review?(ehsan)
Comment 2•11 years ago
|
||
Comment on attachment 826009 [details] [diff] [review] datastore_key.patch Review of attachment 826009 [details] [diff] [review]: ----------------------------------------------------------------- Please update <https://wiki.mozilla.org/WebAPI/DataStore> with these changes when landing.
Attachment #826009 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b90de16dac04
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b90de16dac04
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•