933053 - Remove content of Mozmill addon from README.md files

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Gilles Leblanc]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130911155223

Steps to reproduce:

Visit page https://github.com/mozilla/mozmill and page https://github.com/mozilla/mozmill/tree/master/mozmill.

README.md text is presented on these pages. 


Actual results:

The text on both pages mention the Mozmill addon and include a link for addons.mozilla.org that point to a page that says: "This add-on has been removed by its author.".


Expected results:

The GitHub pages (sourced from the README.md) should not have pointed to the former addon page from the removed addon.

Comment 1

[Gilles Leblanc]

The addon link on the README page leads to a page that says: "This add-on has
been removed by its author.". Furthermore, by searching on Google I was
able to find the following Mozmill Developpers Google Groups message
(https://groups.google.com/forum/#!topic/mozmill-dev/02HwCHWQFRA) that
states the addon was removed because it hadn't been updated in a long
time and support for it had already been dropped.

I originally submitted this as a pull request on GitHub where :davehunt asked me to create a bug for it here.

Comment 2

[Gilles Leblanc]

Attachment: patch

developer.mozilla.org mentions using hg for creating the patch but since this is for a GitHub git repo I used git. If you prefer an hg patch let me know.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 824992 [details] [diff] [review]
patch

Review of attachment 824992 [details] [diff] [review]:
-----------------------------------------------------------------

This is great, thanks! Landed in:
https://github.com/mozilla/mozmill/commit/8d1d3bc64533b30eaa4c096cdb92d27317d083ed

Comment 4

[Gilles Leblanc]

Thank you for such a prompt review!

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Thanks for the patch! :)

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This misses a backport to the hotfix-2.0 branch given that this is our active version.

Landed on hotfix-2.0:
https://github.com/mozilla/mozmill/commit/edf9b98fa251c3374ea0fa862a8db98fb1ea7a9a

Thanks Gilles for your contribution! If you are interested in more please let me know.