Closed Bug 933099 Opened 6 years ago Closed 6 years ago

Don't include windows.h in nsGlobalWindow.cpp at all.

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: khuey, Assigned: khuey)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #825071 - Flags: review?(bzbarsky)
Comment on attachment 825071 [details] [diff] [review]
Patch

r=me

Want to add:

#ifdef _WINDOWS_
#error "Do not include windows.h in this file"
#endif // _WINDOWS_

or some such too to keep it from sneaking back in?
Attachment #825071 - Flags: review?(bzbarsky) → review+
Comment on attachment 825071 [details] [diff] [review]
Patch

>+void mozilla::PrintToDebugger(const char* aStr)
>+{
>+  if (::IsDebuggerPresent()) {
>+    ::OutputDebugStringA(aStr);
>+  }
>+}
[Thus bitrotting my patch to make dump() more Unicode-aware...]
https://hg.mozilla.org/mozilla-central/rev/aab2a2b73b90
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.